feat(sdk): support Swagger V2 model extraction (#4188)

## Proposed change

`extractModelsFromOperation` previously only extracted referenced models
from OpenAPI V3 specs. This PR adds Swagger V2 support:

- `extractRefModel` now handles both `#/components/schemas/` (V3) and
`#/definitions/` (V2) `$ref` paths
- Parameters with `in: "body"` and a `schema` field are now processed
(V2 body parameters)
- Response objects with a top-level `schema` field are now processed (V2
responses)
- V3 parameter schemas (path/query params referencing models) are also
now extracted
- The `isV3` guard in `extractDomains` is removed so model extraction
runs for all spec versions

A new `extractModelsFromSchema` helper consolidates `$ref` and
`items.$ref` extraction logic.

## Related issues

*- No issue associated -*

Author: matthieu-crouzet

packages/@ama-sdk/schematics/cli/genai-context/update-sdk-context.helpers.spec.ts

@@ -1,4 +1,5 @@
 import type {
+  OpenAPIV2,
   OpenAPIV3,
 } from 'openapi-types';
 import {
@@ -76,6 +77,11 @@ describe('update-sdk-context.helpers', () => {
       expect(extractRefModel('#/components/schemas/Order')).toBe('Order');
     });
 
+    it('should extract model name from Swagger V2 #/definitions/ $ref', () => {
+      expect(extractRefModel('#/definitions/Pet')).toBe('Pet');
+      expect(extractRefModel('#/definitions/Order')).toBe('Order');
+    });
+
     it('should return null for undefined or invalid ref', () => {
       expect(extractRefModel(undefined)).toBeNull();
       expect(extractRefModel('')).toBeNull();
@@ -143,6 +149,46 @@ describe('update-sdk-context.helpers', () => {
       const models = extractModelsFromOperation(operation);
       expect(models).toHaveLength(0);
     });
+
+    it('should extract models from Swagger V2 body parameter', () => {
+      const operation = {
+        parameters: [
+          { in: 'body', name: 'body', schema: { $ref: '#/definitions/Pet' } }
+        ],
+        responses: { 200: { description: 'OK' } }
+      } as unknown as OpenAPIV2.OperationObject;
+
+      const models = extractModelsFromOperation(operation);
+      expect(models).toContain('Pet');
+    });
+
+    it('should extract models from Swagger V2 response schema', () => {
+      const operation = {
+        responses: {
+          200: {
+            description: 'OK',
+            schema: { $ref: '#/definitions/Order' }
+          }
+        }
+      } as unknown as OpenAPIV2.OperationObject;
+
+      const models = extractModelsFromOperation(operation);
+      expect(models).toContain('Order');
+    });
+
+    it('should extract models from Swagger V2 array response schema', () => {
+      const operation = {
+        responses: {
+          200: {
+            description: 'OK',
+            schema: { type: 'array', items: { $ref: '#/definitions/Pet' } }
+          }
+        }
+      } as unknown as OpenAPIV2.OperationObject;
+
+      const models = extractModelsFromOperation(operation);
+      expect(models).toContain('Pet');
+    });
   });
 
   describe('inferDomainFromPath', () => {

packages/@ama-sdk/schematics/cli/genai-context/update-sdk-context.helpers.ts

@@ -146,53 +146,63 @@ export function extractRefModel(ref?: string): string | null {
   if (!ref) {
     return null;
   }
-  const match = ref.match(/#\/components\/schemas\/(\w+)/);
+  const match = ref.match(/#\/(?:components\/schemas|definitions)\/(\w+)/);
   return match ? match[1] : null;
 }
 
+/** Schema types that can be passed to extractModelsFromSchema */
+type ExtractableSchema = OpenAPIV2.SchemaObject | OpenAPIV3.SchemaObject | OpenAPIV3.ReferenceObject | OpenAPIV3_1.SchemaObject | OpenAPIV3_1.ReferenceObject;
+
+/**
+ * Extracts model name from a schema object (handles direct $ref and array items $ref)
+ * @param schema
+ */
+function extractModelsFromSchema(schema: ExtractableSchema | undefined): string[] {
+  if (!schema) {
+    return [];
+  }
+  const ref = '$ref' in schema
+    ? schema.$ref
+    : ('items' in schema && schema.items && '$ref' in schema.items
+      ? schema.items.$ref
+      : undefined);
+  const model = extractRefModel(ref);
+  return model ? [model] : [];
+}
+
 /**
- * Extracts all referenced model names from an OpenAPI operation
+ * Extracts all referenced model names from an OpenAPI operation (supports both V2 and V3)
  * @param operation The OpenAPI operation to extract models from
  * @returns Array of model names
  */
-export function extractModelsFromOperation(operation: OpenAPIV3.OperationObject | OpenAPIV3_1.OperationObject): string[] {
+export function extractModelsFromOperation(operation: OpenAPIV2.OperationObject | OpenAPIV3.OperationObject | OpenAPIV3_1.OperationObject): string[] {
   const models: string[] = [];
 
-  const requestBody = operation.requestBody as OpenAPIV3.RequestBodyObject | undefined;
+  const requestBody = (operation as OpenAPIV3.OperationObject).requestBody as OpenAPIV3.RequestBodyObject | undefined;
   if (requestBody?.content) {
     Object.values(requestBody.content).forEach((mediaType) => {
-      const { schema } = mediaType;
-      if (schema && '$ref' in schema) {
-        const model = extractRefModel(schema.$ref);
-        if (model) {
-          models.push(model);
-        }
+      models.push(...extractModelsFromSchema(mediaType.schema));
+    });
+  }
+
+  if (operation.parameters) {
+    operation.parameters.forEach((param) => {
+      if (!('$ref' in param) && 'schema' in param) {
+        models.push(...extractModelsFromSchema(param.schema as ExtractableSchema | undefined));
       }
     });
   }
 
   if (operation.responses) {
     Object.values(operation.responses).forEach((responseOrRef) => {
-      const response = responseOrRef as OpenAPIV3.ResponseObject;
-      if (response.content) {
-        Object.values(response.content).forEach((mediaType) => {
-          const schema = mediaType.schema;
-          if (schema && '$ref' in schema) {
-            const model = extractRefModel(schema.$ref);
-            if (model) {
-              models.push(model);
-            }
-          } else if (schema && 'items' in schema) {
-            const items = schema.items;
-            if (items && '$ref' in items) {
-              const itemModel = extractRefModel(items.$ref);
-              if (itemModel) {
-                models.push(itemModel);
-              }
-            }
-          }
+      if ('content' in responseOrRef) {
+        Object.values((responseOrRef as OpenAPIV3.ResponseObject).content!).forEach((mediaType) => {
+          models.push(...extractModelsFromSchema(mediaType.schema));
         });
       }
+      if ('schema' in responseOrRef) {
+        models.push(...extractModelsFromSchema((responseOrRef as OpenAPIV2.ResponseObject).schema));
+      }
     });
   }
 
@@ -217,7 +227,6 @@ export function inferDomainFromPath(apiPath: string): string {
  */
 export function extractDomains(spec: OpenAPISpec, customDescriptions?: Record<string, string> | null): Map<string, Domain> {
   const domains = new Map<string, Domain>();
-  const isV3 = 'openapi' in spec;
 
   if (spec.tags) {
     spec.tags.forEach((tag) => {
@@ -263,9 +272,7 @@ export function extractDomains(spec: OpenAPISpec, customDescriptions?: Record<st
           path: apiPath
         });
 
-        if (isV3) {
-          extractModelsFromOperation(operation).forEach((model) => domain.models.add(model));
-        }
+        extractModelsFromOperation(operation).forEach((model) => domain.models.add(model));
       });
     });
   }

packages/@o3r/testing/package.json

@@ -253,7 +253,7 @@
     "jest-util": "~30.3.0",
     "rimraf": "^6.0.1",
     "ts-jest": "~29.4.0",
-    "uuid": "~13.0.0"
+    "uuid": "~14.0.0"
   },
   "schematics": "./collection.json",
   "ng-update": {