Skip to content

Commit 65365b0

Browse files
authored
Merge pull request #211 from CoreMedia/update-to-v44.3.0
Update CKEditor5 to v45.2.0
2 parents 0bf4985 + 5901756 commit 65365b0

74 files changed

Lines changed: 2261 additions & 1662 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/build.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,10 @@ jobs:
121121
name: Install
122122
run: |
123123
pnpm install --frozen-lockfile
124+
- name: Create env file
125+
run: |
126+
touch .env
127+
echo CKEDITOR_LICENSE_KEY=${{ secrets.CKEDITOR_LICENSE}}>> .env
124128
- id: build
125129
name: "Build"
126130
run: |
@@ -133,11 +137,12 @@ jobs:
133137
- id: lint
134138
if: ${{ inputs.lint }}
135139
name: "Lint"
136-
run: |
137-
pnpm -r build
140+
run: pnpm lint
138141
- id: utest
139142
if: ${{ inputs.utest }}
140143
name: "Unit Tests"
144+
env:
145+
CKEDITOR_LICENSE_KEY: ${{ secrets.CKEDITOR_LICENSE }}
141146
run: |
142147
pnpm jest
143148
- id: itest

.github/workflows/pre-release.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,17 @@ jobs:
7272
pnpm install --no-frozen-lockfile
7373
git commit -am "ci: Update pnpm-lock.yaml for version ${next_version}"
7474
echo "**Pre-Release Version:** ${next_version}" >> $GITHUB_STEP_SUMMARY
75+
- name: Create env file
76+
run: |
77+
touch .env
78+
echo CKEDITOR_LICENSE_KEY=${{ secrets.CKEDITOR_LICENSE}}>> .env
7579
- name: Build
7680
run: pnpm build
7781
- name: Lint
7882
run: pnpm lint
7983
- name: Test
84+
env:
85+
CKEDITOR_LICENSE_KEY: ${{ secrets.CKEDITOR_LICENSE }}
8086
run: pnpm jest
8187
- name: Playwright Tests
8288
run: pnpm playwright

.github/workflows/release.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ concurrency: ci-${{ github.ref }}
66
on:
77
push:
88
branches:
9-
- main
10-
- 'maintenance/**'
9+
- main
10+
- 'maintenance/**'
1111
workflow_dispatch:
1212
inputs:
1313
release_type:
@@ -113,12 +113,18 @@ jobs:
113113
git commit -am "Set next release-candidate version to: ${next_version}"
114114
pnpm install --no-frozen-lockfile
115115
git commit -am "ci: Update pnpm-lock.yaml for version ${next_version}"
116+
- name: Create env file
117+
run: |
118+
touch .env
119+
echo CKEDITOR_LICENSE_KEY=${{ secrets.CKEDITOR_LICENSE}}>> .env
116120
- name: Build
117121
run: |
118122
pnpm build
119123
- name: Lint
120124
run: pnpm lint
121125
- name: Test
126+
env:
127+
CKEDITOR_LICENSE_KEY: ${{ secrets.CKEDITOR_LICENSE }}
122128
run: pnpm jest
123129
- name: Playwright Tests
124130
run: pnpm playwright

DEVELOPMENT.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@ pnpm -r build
1717

1818
## Testing
1919

20+
Since Version 44 a license key is necessary to use the CkEditor.
21+
Create a file named `.env` in the root of this workspace and add a line
22+
23+
```text
24+
CKEDITOR_LICENSE_KEY=<your-license-key>
25+
```
26+
2027
To run tests use:
2128

2229
```text

README.md

Lines changed: 46 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,13 @@ $ pnpm start
4242

4343
Note, that `pnpm install` requires access to `npm.coremedia.io`.
4444

45+
Since Version 44 a license key is necessary to use the CkEditor.
46+
Create a file named `.env` in the root of this workspace and add a line
47+
48+
```text
49+
CKEDITOR_LICENSE_KEY=<your-license-key>
50+
```
51+
4552
The last command will start a lightweight HTTP server and by default opens
4653
`http://127.0.0.1:8080/sample/` (may vary, if port 8080 is in use) in your
4754
default browser. It will provide a demo of the features providing by the
@@ -83,7 +90,8 @@ workspace usage, are not published and have scope `@coremedia-internal/`.
8390

8491
The subtle difference between `ckeditor5-coremedia-richtext` and
8592
`ckeditor5-coremedia-richtext-support` is, that the latter one just adds support
86-
for attributes from CoreMedia RichText for which no editing actions are configured
93+
for attributes from CoreMedia RichText for which no editing actions are
94+
configured
8795
(yet). Simply speaking, `ckeditor5-coremedia-richtext` ensures, that data can be
8896
read and stored on server, while `ckeditor5-coremedia-richtext-support` ensures,
8997
that all valid CoreMedia RichText attributes are registered as _valid_ within
@@ -169,45 +177,81 @@ implements the described behavior.
169177
* **[GitHub Pages][gp:ckeditor-plugins]:** These pages on GitHub Pages.
170178
* **[Walk-Through Examples](./examples/README.md):** Some step-by-step guides
171179
for customizing CKEditor 5.
172-
* **[Development](./DEVELOPMENT.md):** Hints for developing within this workspace
180+
* **[Development](./DEVELOPMENT.md):** Hints for developing within this
181+
workspace
173182
* **[License](./LICENSE):** Apache 2.0 License Text
174183
* **[Versioning](./VERSIONING.md):** Versioning Policy
175184

176185
<!-- ===========================================================[References] -->
177186

178187
[`ckeditor5-babel-config`]: <./packages/ckeditor5-babel-config> "@coremedia-internal/ckeditor5-babel-config"
188+
179189
[`ckeditor5-bbcode`]: <./packages/ckeditor5-bbcode> "@coremedia/ckeditor5-bbcode"
190+
180191
[`ckeditor5-common`]: <./packages/ckeditor5-common> "@coremedia/ckeditor5-common"
192+
181193
[`ckeditor5-core-common`]: <./packages/ckeditor5-core-common> "@coremedia/ckeditor5-core-common"
194+
182195
[`ckeditor5-coremedia-blocklist`]: <./packages/ckeditor5-coremedia-blocklist> "@coremedia/ckeditor5-coremedia-blocklist"
196+
183197
[`ckeditor5-coremedia-content`]: <./packages/ckeditor5-coremedia-content> "@coremedia/ckeditor5-coremedia-content"
198+
184199
[`ckeditor5-coremedia-content-clipboard`]: <./packages/ckeditor5-coremedia-content-clipboard> "@coremedia/ckeditor5-coremedia-content-clipboard"
200+
185201
[`ckeditor5-coremedia-differencing`]: <./packages/ckeditor5-coremedia-differencing> "@coremedia/ckeditor5-coremedia-differencing"
202+
186203
[`ckeditor5-coremedia-example-data`]: <./packages/ckeditor5-coremedia-example-data> "@coremedia-internal/ckeditor5-coremedia-example-data"
204+
187205
[`ckeditor5-coremedia-images`]: <./packages/ckeditor5-coremedia-images> "@coremedia/ckeditor5-coremedia-images"
206+
188207
[`ckeditor5-coremedia-link`]: <./packages/ckeditor5-coremedia-link> "@coremedia/ckeditor5-coremedia-link"
208+
189209
[`ckeditor5-coremedia-richtext`]: <./packages/ckeditor5-coremedia-richtext> "@coremedia/ckeditor5-coremedia-richtext"
210+
190211
[`ckeditor5-coremedia-richtext-support`]: <./packages/ckeditor5-coremedia-richtext-support> "@coremedia/ckeditor5-coremedia-richtext-support"
212+
191213
[`ckeditor5-coremedia-studio-essentials`]: <./packages/ckeditor5-coremedia-studio-essentials> "@coremedia/ckeditor5-coremedia-studio-essentials"
214+
192215
[`ckeditor5-coremedia-studio-integration`]: <./packages/ckeditor5-coremedia-studio-integration> "@coremedia/ckeditor5-coremedia-studio-integration"
216+
193217
[`ckeditor5-coremedia-studio-integration-mock`]: <./packages/ckeditor5-coremedia-studio-integration-mock> "@coremedia/ckeditor5-coremedia-studio-integration-mock"
218+
194219
[`ckeditor5-data-facade`]: <./packages/ckeditor5-data-facade> "@coremedia/ckeditor5-data-facade"
220+
195221
[`ckeditor5-dataprocessor-support`]: <./packages/ckeditor5-dataprocessor-support> "@coremedia/ckeditor5-dataprocessor-support"
222+
196223
[`ckeditor5-dom-converter`]: <./packages/ckeditor5-dom-converter> "@coremedia/ckeditor5-dom-converter"
224+
197225
[`ckeditor5-dom-support`]: <./packages/ckeditor5-dom-support> "@coremedia/ckeditor5-dom-support"
226+
198227
[`ckeditor5-font-mapper`]: <./packages/ckeditor5-font-mapper> "@coremedia/ckeditor5-font-mapper"
228+
199229
[`ckeditor5-jest-test-helpers`]: <./packages/ckeditor5-jest-test-helpers> "@coremedia-internal/ckeditor5-jest-test-helpers"
230+
200231
[`ckeditor5-link-common`]: <./packages/ckeditor5-link-common> "@coremedia/ckeditor5-link-common"
232+
201233
[`ckeditor5-logging`]: <./packages/ckeditor5-logging> "@coremedia/ckeditor5-logging"
234+
202235
[docs:api]: <https://coremedia.github.io/ckeditor-plugins/docs/api/> "CoreMedia CKEditor 5 Plugins – API Documentation"
236+
203237
[docs:api:badge]: <https://img.shields.io/badge/docs-%F0%9F%93%83%20API-informational?style=for-the-badge>
238+
204239
[badge:docs:GHPages]: <https://img.shields.io/badge/docs-%F0%9F%93%9D%20GH%20Pages-informational?style=for-the-badge>
240+
205241
[badge:license:Apache2]: <https://img.shields.io/badge/license-Apache_2.0-informational?style=for-the-badge>
242+
206243
[badge:engine:nodejs]: <https://img.shields.io/badge/Node.js-20-informational?style=for-the-badge&logo=node.js&logoColor=white>
244+
207245
[badge:engine:pnpm]: <https://img.shields.io/badge/pnpm-8.6.9-informational?style=for-the-badge&logo=pnpm&logoColor=white>
246+
208247
[badge:lang:typescript]: <https://img.shields.io/badge/TypeScript-5.3.3-informational?style=for-the-badge&logo=typescript&logoColor=white>
248+
209249
[badge:ckeditor]: <https://img.shields.io/badge/CKEditor-41.1.0-informational?style=for-the-badge&logo=ckeditor5&logoColor=white>
250+
210251
[CKEditor 4]: <https://ckeditor.com/ckeditor-4/> "CKEditor 4 | Visual Text Editor for HTML"
252+
211253
[CKEditor 5]: <https://ckeditor.com/ckeditor-5/> "CKEditor 5 | Powerful Framework with Modular Architecture"
254+
212255
[CoreMedia CMS]: <https://www.coremedia.com/> "Best-of-Breed Digital Experience Platform CoreMedia"
256+
213257
[gp:ckeditor-plugins]: <https://coremedia.github.io/ckeditor-plugins/> "CoreMedia CKEditor 5 Plugins – GitHub Pages"

app/package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"license": "Apache-2.0",
1616
"private": true,
1717
"dependencies": {
18-
"ckeditor5": "43.3.1",
1918
"@coremedia-internal/ckeditor5-coremedia-example-data": "^1.0.0",
2019
"@coremedia/ckeditor5-bbcode": "23.0.1-rc.2",
2120
"@coremedia/ckeditor5-coremedia-blocklist": "23.0.1-rc.2",
@@ -33,19 +32,22 @@
3332
"@coremedia/ckeditor5-font-mapper": "23.0.1-rc.2",
3433
"@coremedia/ckeditor5-link-common": "23.0.1-rc.2",
3534
"@coremedia/service-agent": "^1.1.5",
35+
"ckeditor5": "45.2.0",
3636
"xml-formatter": "^3.6.2"
3737
},
3838
"devDependencies": {
3939
"@babel/core": "^7.25.2",
40+
"source-map-loader": "^1.0.0",
4041
"@babel/plugin-transform-runtime": "^7.25.4",
4142
"@ckeditor/ckeditor5-dev-translations": "^45.0.8",
4243
"@ckeditor/ckeditor5-dev-utils": "^45.0.8",
4344
"@ckeditor/ckeditor5-inspector": "^4.1.0",
44-
"@ckeditor/ckeditor5-theme-lark": "43.3.1",
45+
"@ckeditor/ckeditor5-theme-lark": "45.2.0",
4546
"@types/node": "^20.14.10",
4647
"babel-loader": "^8.3.0",
4748
"circular-dependency-plugin": "^5.2.2",
4849
"css-loader": "^7.1.2",
50+
"dotenv": "^16.4.7",
4951
"esbuild-loader": "^3.2.0",
5052
"http-server": "^14.1.1",
5153
"postcss": "^8.4.39",

0 commit comments

Comments
 (0)