Skip to content

Commit e941f26

Browse files
committed
fix(ci): skip shared library builds on MSVC to avoid LNK1189
1 parent 5d22698 commit e941f26

41 files changed

Lines changed: 82 additions & 62520 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.gitignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,3 +52,8 @@ allure-*
5252
!build_android.sh
5353
!build_ios.sh
5454

55+
build/
56+
config/
57+
examples/python/
58+
examples/c_api/
59+
logs

cmake/bazel.cmake

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -618,8 +618,11 @@ macro(_add_library _NAME _OPTION)
618618
add_library(
619619
${_NAME}_static STATIC ${_OPTION} $<TARGET_OBJECTS:${_NAME}_objects>
620620
)
621-
if(IOS)
622-
# iOS: create the main target as static too (no shared libs on iOS)
621+
if(IOS OR MSVC)
622+
# iOS/MSVC: no component-level shared libs.
623+
# MSVC: WINDOWS_EXPORT_ALL_SYMBOLS causes LNK1189 when symbol count
624+
# exceeds PE/COFF 65535 limit; building component DLLs is pointless
625+
# since nothing consumes them (Python bindings use static linking).
623626
add_library(
624627
${_NAME} STATIC ${_OPTION} $<TARGET_OBJECTS:${_NAME}_objects>
625628
)

config/construct.yaml.bak

Lines changed: 0 additions & 20 deletions
This file was deleted.

config/construct2.yaml

Lines changed: 0 additions & 24 deletions
This file was deleted.

config/construct_dense.yaml

Lines changed: 0 additions & 21 deletions
This file was deleted.

config/construct_dense_rabitq.yaml

Lines changed: 0 additions & 22 deletions
This file was deleted.

config/construct_dense_rabitq2.yaml

Lines changed: 0 additions & 22 deletions
This file was deleted.

config/search_baseline.yaml.bak

Lines changed: 0 additions & 19 deletions
This file was deleted.

config/search_baseline2.yaml

Lines changed: 0 additions & 19 deletions
This file was deleted.

config/search_current.yaml.bak

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)