Commit f15e692
committed
fix(python): only bundle the DiskANN plugin where it is supported
The wheel install rule for the DiskANN plugin was gated on
`if(TARGET core_knn_diskann)`. That target always exists: on platforms where
DiskAnn is unsupported (macOS, ARM64, ...) it is built from an empty stub
(src/core/algorithm/CMakeLists.txt) with zero exported symbols, and the
runtime load path is compiled out via `#if DISKANN_SUPPORTED`. So the
condition was always true and a useless ~16 KB stub `.dylib` was shipped in
every non-Linux-x86_64 wheel.
Gate the install on `DISKANN_SUPPORTED` instead, so the plugin is packaged
only where it is real (currently Linux x86_64 with libaio).
Verified on macOS arm64: `libcore_knn_diskann.dylib` no longer appears in the
wheel; `import zvec` and other index types are unaffected.1 parent 0ac294a commit f15e692
1 file changed
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | | - | |
183 | | - | |
184 | | - | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
185 | 190 | | |
186 | 191 | | |
187 | 192 | | |
| |||
0 commit comments