ament_cmake_python: --symlink-install does not work correctly if node is renamed

[Jannkar]

I got an issue report on Turtle Nest ROS 2 package, notifying that --symlink-install option does not work correctly for packages that are built for C++ and Python, when a node is renamed.

Here is the full issue report: Jannkar/turtle_nest#15

I believe this might an issue on ament_cmake_python side?

Example of node renaming:

# Install Python executables
install(PROGRAMS
  ${PROJECT_NAME}/python_node.py
  DESTINATION lib/${PROJECT_NAME}
  RENAME python_node
)

[cottsay]

This is indeed not a supported scenario:

ament_cmake/ament_cmake_core/cmake/symlink_install/ament_cmake_symlink_install_programs.cmake

Line 32 in 08de943

"RENAME"

As far as I can tell it isn't omitted for any particular reason. The pattern likely just wasn't popular when ament_cmake symlinking support was implemented. Feel free to submit a PR to add support for that option.