Skip to content

Commit 142f9df

Browse files
committed
Modify the testsuite to acknowledge implementation of the udpate table
1 parent d45ecf4 commit 142f9df

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

crates/catalog/loader/tests/table_suite.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,10 @@ async fn test_catalog_create_table_schema(#[case] kind: CatalogKind) -> Result<(
168168
}
169169

170170
// Common behavior: updating table properties persists through the catalog.
171-
// HMS is excluded because update_table is not supported yet.
172171
#[rstest]
173172
#[case::rest_catalog(CatalogKind::Rest)]
174173
#[case::glue_catalog(CatalogKind::Glue)]
174+
#[case::hms_catalog(CatalogKind::Hms)]
175175
#[case::sql_catalog(CatalogKind::Sql)]
176176
#[case::s3tables_catalog(CatalogKind::S3Tables)]
177177
#[case::memory_catalog(CatalogKind::Memory)]
@@ -211,10 +211,9 @@ async fn test_catalog_update_table_properties(#[case] kind: CatalogKind) -> Resu
211211
}
212212

213213
// Common behavior: update_table_properties is rejected when unsupported.
214-
#[rstest]
215-
#[case::hms_catalog(CatalogKind::Hms)]
216-
#[tokio::test]
217-
async fn test_catalog_update_table_properties_unsupported(#[case] kind: CatalogKind) -> Result<()> {
214+
// Keep this helper for future catalogs that do not implement update_table.
215+
#[allow(dead_code)]
216+
async fn assert_catalog_update_table_properties_unsupported(kind: CatalogKind) -> Result<()> {
218217
let Some(harness) = load_catalog(kind).await else {
219218
return Ok(());
220219
};

0 commit comments

Comments
 (0)