fix: unquoted project path and SolutionDir in dotnet build arguments break when the work folder contains spaces

[credfeto]

Found by AI full-repo code analysis (bugs and performance sweep of non-test projects).

Problem

src/Credfeto.DotNet.Repo.Tools.Build/Services/DotNetBuild.cs:116-130 — $"build {projectFileName} ..." and ("SolutionDir", buildContext.SourceDirectory) interpolate paths into the argument string without quoting; the argv parser splits on spaces.

Failure scenario

--work "/home/user/My Work": DependencyReducer.BuildProjectAsync runs dotnet build /home/user/My Work/... which fails on every project — and because the dependency reducer interprets build failures as "reference needed", it silently reports every reference as required instead of erroring out.

Suggested fix

Wrap interpolated paths in quotes, or move the command builders to ProcessStartInfo.ArgumentList.

Scope

• src/Credfeto.DotNet.Repo.Tools.Build/Services/DotNetBuild.cs (all command builders that embed paths)

Related: #217 (same pattern in git command lines).

[credfeto]

Implementation Plan

Files to change

• src/Credfeto.DotNet.Repo.Tools.Build/Services/DotNetBuild.cs: quote or structurally pass all interpolated paths in the dotnet command builders (project path at line 128, ("SolutionDir", buildContext.SourceDirectory) property at line 118, plus the other $"build ..."/$"test ..." builders at lines 401 and 420 and any path-bearing arguments feeding ExecAsync at line 502)
• src/Credfeto.DotNet.Repo.Tools.Build.Tests/Services/DotNetBuildTests.cs: cover argument construction with paths containing spaces

Approach

Confirmed in the current code: $"build {projectFileName} ..." interpolates the project path unquoted into a single argument string that the argv parser splits on spaces, and the SolutionDir MSBuild property value is likewise unquoted, so a work folder containing a space breaks every build; because DependencyReducer interprets build failures as "reference needed", the failure mode is silent wrong results rather than an error. Preferred fix is structural: switch ExecAsync's ProcessStartInfo construction to ArgumentList, building each argument (including -p:SolutionDir=...) as a discrete entry so no shell-style quoting is needed; where the string-based builders remain, wrap interpolated paths in quotes. The related git command lines are tracked in #217 and not changed here.

Test strategy

Extend the existing xunit DotNetBuildTests to assert the constructed argument list/string keeps a path with spaces as a single argument (via whatever seam the refactor exposes; if none exists, extract the argument-building into a testable pure helper as part of the change). The process-spawning execution path itself remains integration-only per #278. Full solution build and test run.

Assumptions

• Moving to ArgumentList (rather than quoting) is acceptable; it is the more robust fix and keeps SonarAnalyzer happy.

Open questions

None, ready to proceed pending approval.