Skip to content

Commit c0ea649

Browse files
mohsakaPingLiuPing
andcommitted
refactor: Refactor and comment cleanup of velox/dwio iceberg related files.
Co-authored-by: Ping Liu <ping.liu.ping@gmail.com>
1 parent a2cac01 commit c0ea649

5 files changed

Lines changed: 113 additions & 124 deletions

File tree

velox/dwio/parquet/common/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
velox_add_library(
1616
velox_dwio_parquet_common
1717
BloomFilter.cpp
18-
XxHasher.cpp
1918
LevelComparison.cpp
2019
LevelConversion.cpp
20+
XxHasher.cpp
2121
HEADERS
2222
BitStreamUtilsInternal.h
2323
BloomFilter.h

velox/dwio/parquet/writer/arrow/ColumnWriter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ class TypedColumnWriter : public ColumnWriter {
270270
int64_t validBitsOffset,
271271
const T* values) = 0;
272272

273-
// Estimated size of the values that are not written to a page yet
273+
// Estimated size of the values that are not written to a page yet.
274274
virtual int64_t estimatedBufferedValueBytes() const = 0;
275275
};
276276

velox/dwio/parquet/writer/arrow/FileWriter.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,11 @@ class PARQUET_EXPORT RowGroupWriter {
5353
virtual int currentColumn() const = 0;
5454
virtual void close() = 0;
5555

56-
/// \brief Total uncompressed bytes written by the page writer
56+
/// \brief Total uncompressed bytes written by the page writer.
5757
virtual int64_t totalBytesWritten() const = 0;
58-
/// \brief Total bytes still compressed but not written by the page writer
58+
/// \brief Total bytes still compressed but not written by the page writer.
5959
virtual int64_t totalCompressedBytes() const = 0;
60-
/// \brief Total compressed bytes written by the page writer
60+
/// \brief Total compressed bytes written by the page writer.
6161
virtual int64_t totalCompressedBytesWritten() const = 0;
6262

6363
virtual bool buffered() const = 0;
@@ -98,7 +98,7 @@ class PARQUET_EXPORT RowGroupWriter {
9898
/// \brief Total bytes still compressed but not written by the page writer.
9999
/// It will always return 0 from the SerializedPageWriter.
100100
int64_t totalCompressedBytes() const;
101-
/// \brief Total compressed bytes written by the page writer
101+
/// \brief Total compressed bytes written by the page writer.
102102
int64_t totalCompressedBytesWritten() const;
103103
/// Returns whether the current RowGroupWriter is in the buffered mode and is
104104
/// created by calling ParquetFileWriter::appendBufferedRowGroup().

0 commit comments

Comments
 (0)