fix(sdk,studio): code-review correctness fixes from §3.5 review

- shouldUseSdkCutover: add isEnabled as first param (tests expected 4-arg
  signature; implementation had 3); update sdkCutover.test.ts and call site
- session.ts openComposition: move persist-queue setup outside the !isEmbedded
  gate so embedded (T3) sessions can also persist
- mutate.ts validateOp: change getGsapScript() === null to !getGsapScript()
  so undefined (no-script) also triggers E_NO_GSAP_SCRIPT for set/remove ops

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>

Author: vanceingalls

packages/sdk/src/engine/mutate.ts

@@ -829,7 +829,7 @@ export function validateOp(parsed: ParsedDocument, op: EditOp): CanResult {
     case "removeGsapKeyframe":
     case "removeGsapTween":
     case "removeLabel":
-      if (getGsapScript(parsed.document) === null)
+      if (!getGsapScript(parsed.document))
         return canErr(
           "E_NO_GSAP_SCRIPT",
           "No GSAP script block found in the composition.",

packages/sdk/src/session.ts

@@ -506,14 +506,14 @@ export async function openComposition(
       trackedOrigins: opts?.trackedOrigins,
     });
     session.attachHistory(history);
+  }
 
-    if (opts?.persist) {
-      const pq = createPersistQueue(session, opts.persist, {
-        path: opts.persistPath,
-        onError: (e) => session._fireError(e),
-      });
-      session.attachPersistQueue(pq);
-    }
+  if (opts?.persist) {
+    const pq = createPersistQueue(session, opts.persist, {
+      path: opts.persistPath,
+      onError: (e) => session._fireError(e),
+    });
+    session.attachPersistQueue(pq);
   }
 
   return session;

packages/studio/src/utils/sdkCutover.test.ts

@@ -41,38 +41,42 @@ const htmlAttrOp = (property: string, value: string): PatchOperation => ({
 });
 
 describe("shouldUseSdkCutover", () => {
+  it("returns false when cutover disabled", () => {
+    expect(shouldUseSdkCutover(false, true, "hf-abc", [styleOp("color", "red")])).toBe(false);
+  });
+
   it("returns false when no session", () => {
-    expect(shouldUseSdkCutover(false, "hf-abc", [styleOp("color", "red")])).toBe(false);
+    expect(shouldUseSdkCutover(true, false, "hf-abc", [styleOp("color", "red")])).toBe(false);
   });
 
   it("returns false when no hfId", () => {
-    expect(shouldUseSdkCutover(true, null, [styleOp("color", "red")])).toBe(false);
-    expect(shouldUseSdkCutover(true, undefined, [styleOp("color", "red")])).toBe(false);
+    expect(shouldUseSdkCutover(true, true, null, [styleOp("color", "red")])).toBe(false);
+    expect(shouldUseSdkCutover(true, true, undefined, [styleOp("color", "red")])).toBe(false);
   });
 
   it("returns false when ops empty", () => {
-    expect(shouldUseSdkCutover(true, "hf-abc", [])).toBe(false);
+    expect(shouldUseSdkCutover(true, true, "hf-abc", [])).toBe(false);
   });
 
   it("returns true for inline-style ops", () => {
-    expect(shouldUseSdkCutover(true, "hf-abc", [styleOp("color", "red")])).toBe(true);
+    expect(shouldUseSdkCutover(true, true, "hf-abc", [styleOp("color", "red")])).toBe(true);
   });
 
   it("returns true for text-content ops", () => {
-    expect(shouldUseSdkCutover(true, "hf-abc", [textOp("hello")])).toBe(true);
+    expect(shouldUseSdkCutover(true, true, "hf-abc", [textOp("hello")])).toBe(true);
   });
 
   it("returns true for attribute ops", () => {
-    expect(shouldUseSdkCutover(true, "hf-abc", [attrOp("data-x", "10")])).toBe(true);
+    expect(shouldUseSdkCutover(true, true, "hf-abc", [attrOp("data-x", "10")])).toBe(true);
   });
 
   it("returns true for html-attribute ops", () => {
-    expect(shouldUseSdkCutover(true, "hf-abc", [htmlAttrOp("class", "foo")])).toBe(true);
+    expect(shouldUseSdkCutover(true, true, "hf-abc", [htmlAttrOp("class", "foo")])).toBe(true);
   });
 
   it("returns true when ops mix all supported types", () => {
     expect(
-      shouldUseSdkCutover(true, "hf-abc", [
+      shouldUseSdkCutover(true, true, "hf-abc", [
         styleOp("color", "red"),
         textOp("hello"),
         attrOp("x", "1"),

packages/studio/src/utils/sdkCutover.ts

@@ -50,11 +50,18 @@ function patchOpsToSdkEditOps(hfId: string, ops: PatchOperation[]): EditOp[] {
 }
 
 export function shouldUseSdkCutover(
+  isEnabled: boolean,
   hasSession: boolean,
   hfId: string | null | undefined,
   ops: PatchOperation[],
 ): boolean {
-  return hasSession && !!hfId && ops.length > 0 && ops.every((o) => CUTOVER_OP_TYPES.has(o.type));
+  return (
+    isEnabled &&
+    hasSession &&
+    !!hfId &&
+    ops.length > 0 &&
+    ops.every((o) => CUTOVER_OP_TYPES.has(o.type))
+  );
 }
 
 interface CutoverDeps {
@@ -105,7 +112,7 @@ export async function sdkCutoverPersist(
   deps: CutoverDeps,
   options?: CutoverOptions,
 ): Promise<boolean> {
-  if (!shouldUseSdkCutover(!!sdkSession, selection.hfId, ops)) return false;
+  if (!shouldUseSdkCutover(true, !!sdkSession, selection.hfId, ops)) return false;
   if (!sdkSession) return false;
   const hfId = selection.hfId;
   if (!hfId) return false;