ActiveJob report: false not respected

[jaredmoody]

It was surprising to me that every ActiveJob error that occurs is reported to HB even when specifying that errors within the retry loop should not be reported, e.g. retry_on ActiveRecord::Deadlocked, report: false

I think the HB ActiveJob should conform to the Rails API here and not report those errors. From the changelog it looks like there are reasons to prefer native error handlers over Rails.error, but perhaps the report param could be checked before sending off?

[joshuap]

Hey @jaredmoody! We were talking about this last week and Rails seems to make it difficult to check that setting reliably at the point that we're currently reporting the error. Since the current plugin was built prior to the Rails error reporter, what we should probably do is allow the Rails error reporter (which we already integrate with) to report the error to us. We still need to figure out how to attach the context/job params we're currently sending to those reports, and do some testing. We'll take a closer look and let you know when this is fixed.