Commit 72f2d91
CLN: correct issue refs and comments on the read_csv token-length helper
Comment-only follow-ups from reviewing the branch:
- The embedded-NUL comment and test cited GH#66277, the perf issue, and
briefly GH#19886, which this branch does not fix (three of that issue's
four reported cases still fail). Both now cite GH#66415, matching the
whatsnew entry for the fix.
- The helper's precondition named coliter_next; its only caller uses
coliter_next_with_idx, so the precondition is now checkable.
- The test comment explained the wrong thing about the two columns: "a"
covers the words[token_idx + 1] branch and "b" the stream-end branch.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent a73ce30 commit 72f2d91
2 files changed
Lines changed: 11 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2571 | 2571 | | |
2572 | 2572 | | |
2573 | 2573 | | |
2574 | | - | |
| 2574 | + | |
2575 | 2575 | | |
2576 | 2576 | | |
2577 | 2577 | | |
| |||
3062 | 3062 | | |
3063 | 3063 | | |
3064 | 3064 | | |
3065 | | - | |
3066 | | - | |
3067 | | - | |
3068 | | - | |
3069 | | - | |
| 3065 | + | |
| 3066 | + | |
| 3067 | + | |
| 3068 | + | |
| 3069 | + | |
3070 | 3070 | | |
3071 | 3071 | | |
3072 | 3072 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
781 | 781 | | |
782 | 782 | | |
783 | 783 | | |
784 | | - | |
| 784 | + | |
785 | 785 | | |
786 | | - | |
787 | | - | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
788 | 790 | | |
789 | 791 | | |
790 | 792 | | |
| |||
0 commit comments