Merge pull request #83 from liberu-genealogy/copilot/fix-gedcom-import-job

Fix: GedcomImporter never dispatches a queue job; GEDCOM files silently unprocessed after upload

Author: delicatacurtis

src/Jobs/GedcomImportJob.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace FamilyTree365\LaravelGedcom\Jobs;
+
+use FamilyTree365\LaravelGedcom\Facades\GedcomParserFacade;
+use Illuminate\Bus\Queueable;
+use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Foundation\Bus\Dispatchable;
+use Illuminate\Queue\InteractsWithQueue;
+use Illuminate\Queue\SerializesModels;
+
+class GedcomImportJob implements ShouldQueue
+{
+    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
+
+    public function __construct(
+        public readonly string $conn,
+        public readonly string $filename,
+        public readonly string $slug,
+    ) {
+    }
+
+    public function handle(): void
+    {
+        GedcomParserFacade::parse($this->conn, $this->filename, $this->slug, true);
+    }
+}

src/Utils/GedcomImporter.php

@@ -2,20 +2,15 @@
 
 namespace FamilyTree365\LaravelGedcom\Utils;
 
-use FamilyTree365\LaravelGedcom\Facades\GedcomParserFacade;
-use FamilyTree365\LaravelGedcom\Models\Person;
-use Illuminate\Support\Facades\DB;
-use Illuminate\Support\Facades\Storage;
-use Illuminate\Support\Facades\View;
+use FamilyTree365\LaravelGedcom\Jobs\GedcomImportJob;
 
 class GedcomImporter
 {
-    public static function importData($filename)
+    public static function importData(string $filename): void
     {
-        $gedFile = $filename . '.GED';
+        $gedFile = $filename . '.ged';
         $slug = $filename;
 
-        // Code extracted from GedcomImporter.php handle() function (lines 41-42)
-        GedcomParserFacade::parse('mysql', $gedFile, $slug, true);
+        GedcomImportJob::dispatch('mysql', $gedFile, $slug);
     }
 }

tests/Unit/GedcomImportJobTest.php

@@ -0,0 +1,58 @@
+<?php
+
+namespace Tests\Unit;
+
+use Tests\TestCase;
+use FamilyTree365\LaravelGedcom\Facades\GedcomParserFacade;
+use FamilyTree365\LaravelGedcom\Jobs\GedcomImportJob;
+use Illuminate\Support\Facades\Queue;
+
+class GedcomImportJobTest extends TestCase
+{
+    protected function getPackageProviders($app): array
+    {
+        return ['FamilyTree365\LaravelGedcom\ServiceProvider'];
+    }
+
+    public function testJobIsDispatchedByGedcomImporter(): void
+    {
+        Queue::fake();
+
+        \FamilyTree365\LaravelGedcom\Utils\GedcomImporter::importData('family');
+
+        Queue::assertPushed(GedcomImportJob::class, function ($job) {
+            return $job->conn === 'mysql'
+                && $job->filename === 'family.ged'
+                && $job->slug === 'family';
+        });
+    }
+
+    public function testGedcomImporterDispatchesWithLowercaseGedExtension(): void
+    {
+        Queue::fake();
+
+        \FamilyTree365\LaravelGedcom\Utils\GedcomImporter::importData('family');
+
+        Queue::assertPushed(GedcomImportJob::class, function ($job) {
+            return str_ends_with($job->filename, '.ged')
+                && !str_ends_with($job->filename, '.GED');
+        });
+    }
+
+    public function testJobHandleCallsParser(): void
+    {
+        GedcomParserFacade::shouldReceive('parse')
+            ->once()
+            ->with('mysql', 'family.ged', 'family', true)
+            ->andReturn(null);
+
+        $job = new GedcomImportJob('mysql', 'family.ged', 'family');
+        $job->handle();
+    }
+
+    public function testJobImplementsShouldQueue(): void
+    {
+        $job = new GedcomImportJob('mysql', 'test.ged', 'test');
+        $this->assertInstanceOf(\Illuminate\Contracts\Queue\ShouldQueue::class, $job);
+    }
+}