-
Notifications
You must be signed in to change notification settings - Fork 976
Expand file tree
/
Copy pathItemCreateTests.swift
More file actions
1499 lines (1309 loc) · 62.1 KB
/
Copy pathItemCreateTests.swift
File metadata and controls
1499 lines (1309 loc) · 62.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
// SPDX-License-Identifier: LGPL-3.0-or-later
@preconcurrency import FileProvider
@testable import NextcloudFileProviderKit
import NextcloudFileProviderKitMocks
import NextcloudFileProviderXPC
import NextcloudKit
import RealmSwift
import TestInterface
import UniformTypeIdentifiers
import XCTest
/// Captures the quota XPC calls so tests can verify the extension informs the main app on
/// quota refusals (per-item + per-folder summary). See nextcloud/desktop#9598.
final class QuotaCapturingAppProxy: NSObject, AppProtocol {
struct ItemCapture: Equatable {
let fileName: String
let fileBytes: Int64?
let availableBytes: Int64?
let domainIdentifier: String
}
var capturedItems: [ItemCapture] = []
var capturedSummaryDomains: [String] = []
func presentFileActions(_: String, path _: String, remoteItemPath _: String, withDomainIdentifier _: String) {}
func openItemInBrowser(_: String, remoteItemPath _: String, forDomainIdentifier _: String) {}
func copyInternalLink(forItem _: String, remoteItemPath _: String, forDomainIdentifier _: String) {}
func reportSyncStatus(_: String, forDomainIdentifier _: String) {}
func reportItemExcluded(fromSync _: String, fileName _: String, reason _: String, forDomainIdentifier _: String) {}
func reportInsufficientQuota(
forItem _: String,
fileName: String,
fileBytes: NSNumber?,
availableBytes: NSNumber?,
forDomainIdentifier domainIdentifier: String
) {
capturedItems.append(
ItemCapture(
fileName: fileName,
fileBytes: fileBytes?.int64Value,
availableBytes: availableBytes?.int64Value,
domainIdentifier: domainIdentifier
)
)
}
func reportInsufficientQuotaSummary(forDomainIdentifier domainIdentifier: String) {
capturedSummaryDomains.append(domainIdentifier)
}
}
final class ItemCreateTests: NextcloudFileProviderKitTestCase {
static let account = Account(
user: "testUser", id: "testUserId", serverUrl: "https://mock.nc.com", password: "abcd"
)
var rootItem: MockRemoteItem!
static let dbManager = FilesDatabaseManager(account: account, databaseDirectory: makeDatabaseDirectory(), fileProviderDomainIdentifier: NSFileProviderDomainIdentifier("test"), log: FileProviderLogMock())
override func setUp() {
super.setUp()
Realm.Configuration.defaultConfiguration.inMemoryIdentifier = name
rootItem = MockRemoteItem.rootItem(account: Self.account)
}
override func tearDown() {
rootItem.children = []
}
func testCreateFolder() async throws {
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
var folderItemMetadata = SendableItemMetadata(
ocId: "folder-id", fileName: "folder", account: Self.account
)
folderItemMetadata.directory = true
folderItemMetadata.classFile = NKTypeClassFile.directory.rawValue
folderItemMetadata.serverUrl = Self.account.davFilesUrl
let folderItemTemplate = Item(
metadata: folderItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItemMaybe, error) = await Item.create(
basedOn: folderItemTemplate,
contents: nil,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
let createdItem = try XCTUnwrap(createdItemMaybe)
XCTAssertNil(error)
XCTAssertNotNil(createdItem)
XCTAssertEqual(createdItem.metadata.fileName, folderItemMetadata.fileName)
XCTAssertEqual(createdItem.metadata.directory, true)
XCTAssertNotNil(rootItem.children.first { $0.name == folderItemMetadata.name })
XCTAssertNotNil(
rootItem.children.first { $0.identifier == createdItem.itemIdentifier.rawValue }
)
let remoteItem = rootItem.children.first { $0.name == folderItemMetadata.name }
XCTAssertTrue(remoteItem?.directory ?? false)
let dbItem = try XCTUnwrap(
Self.dbManager.itemMetadata(ocId: createdItem.itemIdentifier.rawValue)
)
XCTAssertEqual(dbItem.fileName, folderItemMetadata.fileName)
XCTAssertEqual(dbItem.fileNameView, folderItemMetadata.fileNameView)
XCTAssertEqual(dbItem.directory, folderItemMetadata.directory)
XCTAssertEqual(dbItem.serverUrl, folderItemMetadata.serverUrl)
XCTAssertEqual(dbItem.ocId, createdItem.itemIdentifier.rawValue)
XCTAssertTrue(dbItem.downloaded)
XCTAssertTrue(dbItem.uploaded)
XCTAssertTrue(createdItem.isDownloaded)
XCTAssertTrue(createdItem.isUploaded)
}
/// Upload integrity guard (F1): when the server reports it stored a different number of bytes
/// than the local file contains, `create` must NOT record the item as a clean upload. It
/// returns a *transient* error (so the File Provider system automatically retries the create)
/// and best-effort removes the partial remote object, instead of surfacing a torn file as synced.
func testCreateFileFailsOnUploadSizeMismatch() async throws {
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
var fileItemMetadata = SendableItemMetadata(
ocId: "file-id", fileName: "file", account: Self.account
)
fileItemMetadata.classFile = NKTypeClassFile.document.rawValue
let tempUrl = FileManager.default.temporaryDirectory
.appendingPathComponent("integrity-mismatch-create")
try Data("Hello world".utf8).write(to: tempUrl)
// Simulate the server storing fewer bytes than we sent (a torn transfer).
remoteInterface.uploadResponseSizeOverride = 3
let fileItemTemplate = Item(
metadata: fileItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItemMaybe, error) = await Item.create(
basedOn: fileItemTemplate,
contents: tempUrl,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
XCTAssertNil(createdItemMaybe)
// The error must be *transient* (NSCocoaErrorDomain) so the system automatically retries
// the create rather than backing off until the provider signals resolution.
let nsError = try XCTUnwrap(error as NSError?)
XCTAssertEqual(nsError.domain, NSCocoaErrorDomain)
XCTAssertEqual(nsError.code, NSFileWriteUnknownError)
// Nothing must be recorded as a clean upload for this item.
XCTAssertNil(Self.dbManager.itemMetadata(ocId: "file-id"))
}
func testCreateFile() async throws {
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
var fileItemMetadata = SendableItemMetadata(
ocId: "file-id", fileName: "file", account: Self.account
)
fileItemMetadata.classFile = NKTypeClassFile.document.rawValue
let tempUrl = FileManager.default.temporaryDirectory.appendingPathComponent("file")
try Data("Hello world".utf8).write(to: tempUrl)
let fileItemTemplate = Item(
metadata: fileItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItemMaybe, error) = await Item.create(
basedOn: fileItemTemplate,
contents: tempUrl,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
let createdItem = try XCTUnwrap(createdItemMaybe)
XCTAssertNil(error)
XCTAssertNotNil(createdItem)
XCTAssertEqual(createdItem.metadata.fileName, fileItemMetadata.fileName)
XCTAssertEqual(createdItem.metadata.directory, fileItemMetadata.directory)
let remoteItem = try XCTUnwrap(
rootItem.children.first { $0.identifier == createdItem.itemIdentifier.rawValue }
)
XCTAssertEqual(remoteItem.name, fileItemMetadata.fileName)
XCTAssertEqual(remoteItem.directory, fileItemMetadata.directory)
let dbItem = try XCTUnwrap(
Self.dbManager.itemMetadata(ocId: createdItem.itemIdentifier.rawValue)
)
XCTAssertEqual(dbItem.fileName, fileItemMetadata.fileName)
XCTAssertEqual(dbItem.fileNameView, fileItemMetadata.fileNameView)
XCTAssertEqual(dbItem.directory, fileItemMetadata.directory)
XCTAssertEqual(dbItem.serverUrl, fileItemMetadata.serverUrl)
XCTAssertEqual(dbItem.ocId, createdItem.itemIdentifier.rawValue)
XCTAssertTrue(dbItem.downloaded)
XCTAssertTrue(dbItem.uploaded)
XCTAssertTrue(createdItem.isDownloaded)
XCTAssertTrue(createdItem.isUploaded)
}
/// Regression test for the same root cause as
/// `testModifyFilePreservesLocalContentModificationDateWhenServerTruncates`,
/// but on the create path: when the server truncates the upload-response
/// mtime to 1 s precision, the returned `Item.creationDate` and
/// `Item.contentModificationDate` must reflect the template's sub-second
/// values rather than the truncated server response.
func testCreateFilePreservesLocalDatesWhenServerTruncates() async throws {
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
remoteInterface.uploadResponseMtimeTruncation = 1.0
let preciseCreationDate = Date(timeIntervalSince1970: 1_747_564_300.123456)
let preciseMtime = Date(timeIntervalSince1970: 1_747_564_337.456789)
var fileItemMetadata = SendableItemMetadata(
ocId: "file-precise-dates", fileName: "file-precise-dates", account: Self.account
)
fileItemMetadata.classFile = NKTypeClassFile.document.rawValue
fileItemMetadata.creationDate = preciseCreationDate
fileItemMetadata.date = preciseMtime
let tempUrl = FileManager.default.temporaryDirectory
.appendingPathComponent("file-precise-dates")
try Data("Hello, precise dates!".utf8).write(to: tempUrl)
let fileItemTemplate = Item(
metadata: fileItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItemMaybe, error) = await Item.create(
basedOn: fileItemTemplate,
contents: tempUrl,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
XCTAssertNil(error)
let createdItem = try XCTUnwrap(createdItemMaybe)
XCTAssertEqual(createdItem.creationDate, preciseCreationDate)
XCTAssertEqual(createdItem.contentModificationDate, preciseMtime)
let truncatedMtime = Date(
timeIntervalSince1970: preciseMtime.timeIntervalSince1970.rounded(.down)
)
XCTAssertNotEqual(truncatedMtime, preciseMtime)
XCTAssertNotEqual(createdItem.contentModificationDate, truncatedMtime)
let dbItem = try XCTUnwrap(
Self.dbManager.itemMetadata(ocId: createdItem.itemIdentifier.rawValue)
)
XCTAssertEqual(dbItem.creationDate, preciseCreationDate)
XCTAssertEqual(dbItem.date, preciseMtime)
}
/// Defensive coverage for the secondary fallback: if the system passes a
/// template whose `creationDate` / `contentModificationDate` are nil (an
/// `NSFileProviderItem` not built from one of our `Item` instances), the
/// fix must fall through to the server's response date rather than
/// silently substituting `Date()` (the previous behaviour, which would
/// anchor the new metadata to the current wall clock for no good reason).
func testCreateFileFallsBackToServerDateWhenTemplateHasNilDates() async throws {
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
let template: NSFileProviderItem = MockFileProviderItem(
identifier: .init("file-nil-dates"),
filename: "file-nil-dates",
isUploaded: false
)
// MockFileProviderItem doesn't declare creationDate / contentModificationDate, so
// both flow through the @objc-optional protocol's default-nil. That's exactly the
// shape this test wants: an item from outside our `Item` type where the system
// simply didn't furnish those fields.
XCTAssertNil(template.creationDate ?? nil, "Test setup expects template.creationDate to be nil")
XCTAssertNil(template.contentModificationDate ?? nil, "Test setup expects template.contentModificationDate to be nil")
let tempUrl = FileManager.default.temporaryDirectory
.appendingPathComponent("file-nil-dates")
try Data("Hello, nil dates!".utf8).write(to: tempUrl)
let beforeUpload = Date()
let (createdItemMaybe, error) = await Item.create(
basedOn: template,
contents: tempUrl,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
let afterUpload = Date()
XCTAssertNil(error)
let createdItem = try XCTUnwrap(createdItemMaybe)
// The mock echoes the (defaulted-to-now) mtime back as the response,
// so the resulting dates should equal the server-derived value rather
// than a second invocation of `Date()` taken after the response. We
// can't pin to an exact value (the mock initialises with `Date()` when
// the template hands it nil), but it must land within the upload
// window — and `creationDate` and `contentModificationDate` must agree
// with each other.
let creationDate = try XCTUnwrap(createdItem.creationDate)
let modificationDate = try XCTUnwrap(createdItem.contentModificationDate)
XCTAssertEqual(creationDate, modificationDate, "Both dates should derive from the same server response value")
XCTAssertGreaterThanOrEqual(creationDate, beforeUpload)
XCTAssertLessThanOrEqual(creationDate, afterUpload)
}
/// Pre-flight quota gate: when the parent's `quotaAvailableBytes` is below the local
/// file size, refuse the upload up-front with `.insufficientQuota` and never call
/// the remote upload endpoint. See nextcloud/desktop#9598.
func testCreateFileBlockedByInsufficientQuota() async throws {
rootItem.quotaAvailableBytes = 4 // less than the file we're about to upload
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
var fileItemMetadata = SendableItemMetadata(
ocId: "file-id", fileName: "file", account: Self.account
)
fileItemMetadata.classFile = NKTypeClassFile.document.rawValue
let tempUrl = FileManager.default.temporaryDirectory
.appendingPathComponent("quota-blocked-create")
try Data("Hello world".utf8).write(to: tempUrl) // 11 bytes > 4 bytes available
let fileItemTemplate = Item(
metadata: fileItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItem, error) = await Item.create(
basedOn: fileItemTemplate,
contents: tempUrl,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
XCTAssertNil(createdItem)
XCTAssertEqual((error as? NSFileProviderError)?.code, .insufficientQuota)
// No upload was attempted: the file did not appear under the remote root.
XCTAssertNil(rootItem.children.first { $0.name == fileItemMetadata.fileName })
}
/// When an upload is refused by the pre-flight quota gate, the extension must inform the
/// main app via XPC so it can surface a per-item activity entry plus a per-folder summary
/// entry with a "Retry all uploads" button. See nextcloud/desktop#9598.
func testCreateFileRefusedByQuotaReportsToMainApp() async throws {
rootItem.quotaAvailableBytes = 4
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
var fileItemMetadata = SendableItemMetadata(
ocId: "file-id", fileName: "file-quota-report", account: Self.account
)
fileItemMetadata.classFile = NKTypeClassFile.document.rawValue
let tempUrl = FileManager.default.temporaryDirectory
.appendingPathComponent("quota-report-create")
try Data("Hello world".utf8).write(to: tempUrl) // 11 bytes > 4 bytes available
let domain = NSFileProviderDomain(
identifier: NSFileProviderDomainIdentifier("test-domain-create"),
displayName: "test"
)
let proxy = QuotaCapturingAppProxy()
let fileItemTemplate = Item(
metadata: fileItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItem, error) = await Item.create(
basedOn: fileItemTemplate,
contents: tempUrl,
domain: domain,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
appProxy: proxy,
log: FileProviderLogMock()
)
XCTAssertNil(createdItem)
XCTAssertEqual((error as? NSFileProviderError)?.code, .insufficientQuota)
XCTAssertEqual(proxy.capturedItems.count, 1)
let itemCapture = try XCTUnwrap(proxy.capturedItems.first)
XCTAssertEqual(itemCapture.fileName, "file-quota-report")
XCTAssertEqual(itemCapture.domainIdentifier, "test-domain-create")
XCTAssertEqual(itemCapture.fileBytes, 11)
XCTAssertEqual(proxy.capturedSummaryDomains, ["test-domain-create"])
}
/// Negative `quotaAvailableBytes` (the default for accounts with no quota set) must
/// not trigger the new pre-flight gate; the upload proceeds normally.
func testCreateFileWithUnknownQuotaProceeds() async throws {
XCTAssertEqual(rootItem.quotaAvailableBytes, -1) // default sentinel
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
var fileItemMetadata = SendableItemMetadata(
ocId: "file-id", fileName: "file-no-quota", account: Self.account
)
fileItemMetadata.classFile = NKTypeClassFile.document.rawValue
let tempUrl = FileManager.default.temporaryDirectory
.appendingPathComponent("quota-unknown-create")
try Data("Hello world".utf8).write(to: tempUrl)
let fileItemTemplate = Item(
metadata: fileItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItemMaybe, error) = await Item.create(
basedOn: fileItemTemplate,
contents: tempUrl,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
XCTAssertNil(error)
let createdItem = try XCTUnwrap(createdItemMaybe)
XCTAssertNotNil(rootItem.children.first { $0.identifier == createdItem.itemIdentifier.rawValue })
}
func testCreateFileIntoFolder() async throws {
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
var folderItemMetadata = SendableItemMetadata(
ocId: "folder-id", fileName: "folder", account: Self.account
)
folderItemMetadata.directory = true
folderItemMetadata.classFile = NKTypeClassFile.directory.rawValue
folderItemMetadata.serverUrl = Self.account.davFilesUrl
let folderItemTemplate = Item(
metadata: folderItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdFolderItemMaybe, folderError) = await Item.create(
basedOn: folderItemTemplate,
contents: nil,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
XCTAssertNil(folderError)
let createdFolderItem = try XCTUnwrap(createdFolderItemMaybe)
let fileRelativeRemotePath = "/folder"
var fileItemMetadata = SendableItemMetadata(
ocId: "file-id", fileName: "file", account: Self.account
)
fileItemMetadata.classFile = NKTypeClassFile.document.rawValue
fileItemMetadata.serverUrl = Self.account.davFilesUrl + fileRelativeRemotePath
let fileItemTemplate = Item(
metadata: fileItemMetadata,
parentItemIdentifier: createdFolderItem.itemIdentifier,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let tempUrl = FileManager.default.temporaryDirectory.appendingPathComponent("file")
try Data("Hello world".utf8).write(to: tempUrl)
let (createdFileItemMaybe, fileError) = await Item.create(
basedOn: fileItemTemplate,
contents: tempUrl,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
let createdFileItem = try XCTUnwrap(createdFileItemMaybe)
XCTAssertNil(fileError)
XCTAssertNotNil(createdFileItem)
let remoteFolderItem = rootItem.children.first { $0.name == "folder" }
XCTAssertNotNil(remoteFolderItem)
XCTAssertFalse(remoteFolderItem?.children.isEmpty ?? true)
let dbItem = try XCTUnwrap(
Self.dbManager.itemMetadata(ocId: createdFileItem.itemIdentifier.rawValue)
)
XCTAssertEqual(dbItem.fileName, fileItemMetadata.fileName)
XCTAssertEqual(dbItem.fileNameView, fileItemMetadata.fileNameView)
XCTAssertEqual(dbItem.directory, fileItemMetadata.directory)
XCTAssertEqual(dbItem.serverUrl, fileItemMetadata.serverUrl)
XCTAssertEqual(dbItem.ocId, createdFileItem.itemIdentifier.rawValue)
XCTAssertTrue(dbItem.downloaded)
XCTAssertTrue(dbItem.uploaded)
let parentDbItem = try XCTUnwrap(
Self.dbManager.itemMetadata(ocId: createdFolderItem.itemIdentifier.rawValue)
)
XCTAssertEqual(parentDbItem.fileName, folderItemMetadata.fileName)
XCTAssertEqual(parentDbItem.fileNameView, folderItemMetadata.fileNameView)
XCTAssertEqual(parentDbItem.directory, folderItemMetadata.directory)
XCTAssertEqual(parentDbItem.serverUrl, folderItemMetadata.serverUrl)
XCTAssertTrue(parentDbItem.downloaded)
XCTAssertTrue(parentDbItem.uploaded)
}
/// Verify that bundles are refused at the file provider boundary with `.excludedFromSync`
/// and that nothing is uploaded to the (mock) server. Replaces the previous
/// `testCreateBundle` test, which validated the now-removed recursive-mirror code path.
/// See https://github.com/nextcloud/desktop/issues/9827.
func testCreateBundleIsExcluded() async {
let db = Self.dbManager.ncDatabase() // Strong ref for in memory test db
debugPrint(db)
let keynoteBundleFilename = "test.key"
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
var bundleItemMetadata = SendableItemMetadata(
ocId: "keynotebundleid", fileName: keynoteBundleFilename, account: Self.account
)
bundleItemMetadata.directory = true
bundleItemMetadata.serverUrl = Self.account.davFilesUrl
bundleItemMetadata.classFile = NKTypeClassFile.directory.rawValue
bundleItemMetadata.contentType = UTType.bundle.identifier
let bundleItemTemplate = Item(
metadata: bundleItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (item, error) = await Item.create(
basedOn: bundleItemTemplate,
contents: nil,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
// The exclusion path returns a placeholder item plus the system-recognised exclusion error.
XCTAssertNotNil(item)
XCTAssertEqual((error as? NSFileProviderError)?.code, .excludedFromSync)
// Nothing should have reached the (mock) server.
XCTAssertNil(rootItem.children.first { $0.name == keynoteBundleFilename })
}
/// Same expectation for `.app` (`com.apple.application-bundle`) — historically the most
/// problematic bundle type for our recursive-mirror approach because of internal symlinks.
func testCreateDotAppIsExcluded() async {
let db = Self.dbManager.ncDatabase()
debugPrint(db)
let appFilename = "Test.app"
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
var appMetadata = SendableItemMetadata(
ocId: "test-app-id", fileName: appFilename, account: Self.account
)
appMetadata.directory = true
appMetadata.serverUrl = Self.account.davFilesUrl
appMetadata.classFile = NKTypeClassFile.directory.rawValue
appMetadata.contentType = UTType.applicationBundle.identifier
let appItemTemplate = Item(
metadata: appMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (item, error) = await Item.create(
basedOn: appItemTemplate,
contents: nil,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
XCTAssertNotNil(item)
XCTAssertEqual((error as? NSFileProviderError)?.code, .excludedFromSync)
XCTAssertNil(rootItem.children.first { $0.name == appFilename })
}
func testCreateFileChunked() async throws {
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
var fileItemMetadata = SendableItemMetadata(
ocId: "file-id", fileName: "file", account: Self.account
)
fileItemMetadata.classFile = NKTypeClassFile.document.rawValue
let chunkSize = 2
let tempUrl = FileManager.default.temporaryDirectory.appendingPathComponent("file")
let tempData = Data(repeating: 1, count: chunkSize * 3)
try tempData.write(to: tempUrl)
let fileItemTemplate = Item(
metadata: fileItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItemMaybe, error) = await Item.create(
basedOn: fileItemTemplate,
contents: tempUrl,
account: Self.account,
remoteInterface: remoteInterface,
forcedChunkSize: chunkSize,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
let createdItem = try XCTUnwrap(createdItemMaybe)
XCTAssertNil(error)
XCTAssertNotNil(createdItem)
XCTAssertEqual(createdItem.metadata.fileName, fileItemMetadata.fileName)
XCTAssertEqual(createdItem.metadata.directory, fileItemMetadata.directory)
let remoteItem = try XCTUnwrap(
rootItem.children.first { $0.identifier == createdItem.itemIdentifier.rawValue }
)
XCTAssertEqual(remoteItem.name, fileItemMetadata.fileName)
XCTAssertEqual(remoteItem.directory, fileItemMetadata.directory)
XCTAssertEqual(remoteItem.data, tempData)
let dbItem = try XCTUnwrap(
Self.dbManager.itemMetadata(ocId: createdItem.itemIdentifier.rawValue)
)
XCTAssertEqual(dbItem.fileName, fileItemMetadata.fileName)
XCTAssertEqual(dbItem.fileNameView, fileItemMetadata.fileNameView)
XCTAssertEqual(dbItem.directory, fileItemMetadata.directory)
XCTAssertEqual(dbItem.serverUrl, fileItemMetadata.serverUrl)
XCTAssertEqual(dbItem.ocId, createdItem.itemIdentifier.rawValue)
XCTAssertTrue(dbItem.downloaded)
XCTAssertTrue(dbItem.uploaded)
}
func testCreateFileChunkedResumed() async throws {
let chunkSize = 2
let expectedChunkUploadIdBase = UUID().uuidString // Check that illegal characters are stripped.
let illegalChunkUploadId = expectedChunkUploadIdBase + "/" // Check that illegal characters are stripped.
let tempUrl = FileManager.default.temporaryDirectory.appendingPathComponent("file")
let tempData = Data(repeating: 1, count: chunkSize * 3)
try tempData.write(to: tempUrl)
// New-item creation has no persisted ItemMetadata (the OS supplies the template), so the chunk
// id is derived from the template's itemIdentifier plus the content's (size, modificationDate),
// with illegal path characters stripped. Seed the prior interrupted attempt under exactly that
// derived id so the resume path recognises identical content.
let modificationDate = Date(timeIntervalSince1970: 1_700_000_000)
let chunkUploadId = chunkUploadIdentifier(
forItemWithIdentifier: illegalChunkUploadId,
fileSize: Int64(tempData.count),
modificationDate: modificationDate
)
XCTAssertTrue(chunkUploadId.hasPrefix(expectedChunkUploadIdBase + "_"))
XCTAssertFalse(chunkUploadId.contains("/"))
let previousUploadedChunkNum = 1
let preexistingChunk = RemoteFileChunk(
fileName: String(previousUploadedChunkNum),
size: Int64(chunkSize),
remoteChunkStoreFolderName: chunkUploadId
)
let db = Self.dbManager.ncDatabase()
try db.write {
db.add([
RemoteFileChunk(
fileName: String(previousUploadedChunkNum + 1),
size: Int64(chunkSize),
remoteChunkStoreFolderName: chunkUploadId
),
RemoteFileChunk(
fileName: String(previousUploadedChunkNum + 2),
size: Int64(chunkSize),
remoteChunkStoreFolderName: chunkUploadId
)
])
}
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
remoteInterface.currentChunks = [chunkUploadId: [preexistingChunk]]
var fileItemMetadata = SendableItemMetadata(
ocId: illegalChunkUploadId, fileName: "file", account: Self.account
)
fileItemMetadata.classFile = NKTypeClassFile.document.rawValue
fileItemMetadata.date = modificationDate
let fileItemTemplate = Item(
metadata: fileItemMetadata,
parentItemIdentifier: .rootContainer,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItemMaybe, error) = await Item.create(
basedOn: fileItemTemplate,
contents: tempUrl,
account: Self.account,
remoteInterface: remoteInterface,
forcedChunkSize: chunkSize,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
let createdItem = try XCTUnwrap(createdItemMaybe)
XCTAssertNil(error)
XCTAssertNotNil(createdItem)
XCTAssertEqual(createdItem.metadata.fileName, fileItemMetadata.fileName)
XCTAssertEqual(createdItem.metadata.directory, fileItemMetadata.directory)
let remoteItem = try XCTUnwrap(
rootItem.children.first { $0.identifier == createdItem.itemIdentifier.rawValue }
)
XCTAssertEqual(remoteItem.name, fileItemMetadata.fileName)
XCTAssertEqual(remoteItem.directory, fileItemMetadata.directory)
XCTAssertEqual(remoteItem.data, tempData)
XCTAssertEqual(
remoteInterface.completedChunkTransferSize[chunkUploadId],
Int64(tempData.count) - preexistingChunk.size
)
let dbItem = try XCTUnwrap(
Self.dbManager.itemMetadata(ocId: createdItem.itemIdentifier.rawValue)
)
XCTAssertEqual(dbItem.fileName, fileItemMetadata.fileName)
XCTAssertEqual(dbItem.fileNameView, fileItemMetadata.fileNameView)
XCTAssertEqual(dbItem.directory, fileItemMetadata.directory)
XCTAssertEqual(dbItem.serverUrl, fileItemMetadata.serverUrl)
XCTAssertEqual(dbItem.ocId, createdItem.itemIdentifier.rawValue)
XCTAssertNil(dbItem.chunkUploadId)
XCTAssertTrue(dbItem.downloaded)
XCTAssertTrue(dbItem.uploaded)
}
func testCreateDoesNotPropagateIgnoredFile() async {
let ignoredMatcher = IgnoredFilesMatcher(ignoreList: ["*.tmp", "/build/"], log: FileProviderLogMock())
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
// We'll create a file that matches the ignored pattern
let parentIdentifier = NSFileProviderItemIdentifier.rootContainer
let metadata = SendableItemMetadata(
ocId: "ignored-file-id", fileName: "foo.tmp", account: Self.account
)
let itemTemplate = Item(
metadata: metadata,
parentItemIdentifier: parentIdentifier,
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItem, error) = await Item.create(
basedOn: itemTemplate,
contents: nil,
account: Self.account,
remoteInterface: remoteInterface,
ignoredFiles: ignoredMatcher,
progress: .init(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
// Assert
XCTAssertEqual(error as? NSFileProviderError, NSFileProviderError(.excludedFromSync))
XCTAssertNotNil(createdItem)
XCTAssertEqual(createdItem?.isUploaded, false)
XCTAssertEqual(createdItem?.isDownloaded, true)
XCTAssertTrue(rootItem.children.isEmpty)
}
func testCreateLockFileTriggersRemoteLockInsteadOfUpload() async {
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
// Setup remote folder and file
let folderRemote = MockRemoteItem(
identifier: "folder",
versionIdentifier: "1",
name: "folder",
remotePath: Self.account.davFilesUrl + "/folder",
directory: true,
account: Self.account.ncKitAccount,
username: Self.account.username,
userId: Self.account.id,
serverUrl: Self.account.serverUrl
)
let targetFileName = "MyDoc.odt"
let targetRemote = MockRemoteItem(
identifier: "folder/\(targetFileName)",
versionIdentifier: "1",
name: targetFileName,
remotePath: folderRemote.remotePath + "/" + targetFileName,
data: Data("test data".utf8),
locked: false,
account: Self.account.ncKitAccount,
username: Self.account.username,
userId: Self.account.id,
serverUrl: Self.account.serverUrl
)
folderRemote.children = [targetRemote]
folderRemote.parent = rootItem
rootItem.children = [folderRemote]
// Insert folder and target file into DB
var folderMetadata = SendableItemMetadata(
ocId: folderRemote.identifier, fileName: "folder", account: Self.account
)
folderMetadata.directory = true
Self.dbManager.addItemMetadata(folderMetadata)
var targetMetadata = SendableItemMetadata(
ocId: targetRemote.identifier, fileName: targetFileName, account: Self.account
)
targetMetadata.serverUrl += "/folder"
Self.dbManager.addItemMetadata(targetMetadata)
// Construct the lock file metadata
let lockFileName = ".~lock.\(targetFileName)#"
var lockFileMetadata = SendableItemMetadata(
ocId: "lock-id", fileName: lockFileName, account: Self.account
)
lockFileMetadata.serverUrl += "/folder"
let lockItemTemplate = Item(
metadata: lockFileMetadata,
parentItemIdentifier: .init(folderMetadata.ocId),
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItem, error) = await Item.create(
basedOn: lockItemTemplate,
contents: nil,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
XCTAssertNotNil(createdItem)
XCTAssertEqual(createdItem?.isUploaded, false)
XCTAssertEqual(createdItem?.isDownloaded, true)
XCTAssertNil(error)
XCTAssertNotNil(Self.dbManager.itemMetadata(ocId: lockFileMetadata.ocId))
XCTAssertTrue(targetRemote.locked)
}
func testCreateLockFileUnactionableWithoutCapabilities() async throws {
let remoteInterface = MockRemoteInterface(account: Self.account, rootItem: rootItem)
XCTAssert(remoteInterface.capabilities.contains(##""locking": "1.0","##))
remoteInterface.capabilities =
remoteInterface.capabilities.replacingOccurrences(of: ##""locking": "1.0","##, with: "")
// Setup remote folder and file
let folderRemote = MockRemoteItem(
identifier: "folder",
versionIdentifier: "1",
name: "folder",
remotePath: Self.account.davFilesUrl + "/folder",
directory: true,
account: Self.account.ncKitAccount,
username: Self.account.username,
userId: Self.account.id,
serverUrl: Self.account.serverUrl
)
let targetFileName = "MyDoc.odt"
let targetRemote = MockRemoteItem(
identifier: "folder/\(targetFileName)",
versionIdentifier: "1",
name: targetFileName,
remotePath: folderRemote.remotePath + "/" + targetFileName,
data: Data("test data".utf8),
locked: false,
account: Self.account.ncKitAccount,
username: Self.account.username,
userId: Self.account.id,
serverUrl: Self.account.serverUrl
)
folderRemote.children = [targetRemote]
folderRemote.parent = rootItem
rootItem.children = [folderRemote]
// Insert folder and target file into DB
var folderMetadata = SendableItemMetadata(
ocId: folderRemote.identifier, fileName: "folder", account: Self.account
)
folderMetadata.directory = true
Self.dbManager.addItemMetadata(folderMetadata)
var targetMetadata = SendableItemMetadata(
ocId: targetRemote.identifier, fileName: targetFileName, account: Self.account
)
targetMetadata.serverUrl += "/folder"
Self.dbManager.addItemMetadata(targetMetadata)
// Construct the lock file metadata
let lockFileName = ".~lock.\(targetFileName)#"
var lockFileMetadata = SendableItemMetadata(
ocId: "lock-id", fileName: lockFileName, account: Self.account
)
lockFileMetadata.serverUrl += "/folder"
let lockItemTemplate = Item(
metadata: lockFileMetadata,
parentItemIdentifier: .init(folderMetadata.ocId),
account: Self.account,
remoteInterface: remoteInterface,
dbManager: Self.dbManager
)
let (createdItem, error) = await Item.create(
basedOn: lockItemTemplate,
contents: nil,
account: Self.account,
remoteInterface: remoteInterface,
progress: Progress(),
dbManager: Self.dbManager,
log: FileProviderLogMock()
)
XCTAssertNil(createdItem)
let unwrappedError = try XCTUnwrap(error) as? NSFileProviderError
XCTAssertEqual(unwrappedError, NSFileProviderError(.excludedFromSync))
XCTAssertNil(Self.dbManager.itemMetadata(ocId: lockFileMetadata.ocId))
XCTAssertFalse(targetRemote.locked)
}
/// An Adobe lock file name does not encode the guarded document's extension, so the document
/// is resolved by matching a sibling file. Once resolved it is locked on the server just like
/// for Office lock files, while the lock file itself stays local and is never uploaded.