From 3cab57873564e2f09ccec50fe6e34886246081ca Mon Sep 17 00:00:00 2001 From: mayur-shenoy Date: Mon, 29 Jun 2026 18:57:23 +0530 Subject: [PATCH] types: fix deleteCookie attributes Signed-off-by: mayur-shenoy --- test/types/cookies.test-d.ts | 11 +++++++++++ types/cookies.d.ts | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 test/types/cookies.test-d.ts diff --git a/test/types/cookies.test-d.ts b/test/types/cookies.test-d.ts new file mode 100644 index 00000000000..59fedb124e7 --- /dev/null +++ b/test/types/cookies.test-d.ts @@ -0,0 +1,11 @@ +import { expectError, expectType } from 'tsd' +import { Headers, deleteCookie } from '../..' + +const headers = new Headers() + +expectType(deleteCookie(headers, 'session')) +expectType(deleteCookie(headers, 'session', { domain: 'example.com' })) +expectType(deleteCookie(headers, 'session', { path: '/' })) +expectType(deleteCookie(headers, 'session', { domain: 'example.com', path: '/' })) + +expectError(deleteCookie(headers, 'session', { name: 'session' })) diff --git a/types/cookies.d.ts b/types/cookies.d.ts index f746d35853f..d8dc1f60c57 100644 --- a/types/cookies.d.ts +++ b/types/cookies.d.ts @@ -18,7 +18,7 @@ export interface Cookie { export function deleteCookie ( headers: Headers, name: string, - attributes?: { name?: string, domain?: string } + attributes?: { path?: string, domain?: string } ): void export function getCookies (headers: Headers): Record