8386092: Implement JEP: Deprecate the macOS/x64 Port for Removal#31684
8386092: Implement JEP: Deprecate the macOS/x64 Port for Removal#31684vidmik wants to merge 1 commit into
Conversation
|
👋 Welcome back mikael! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
dholmes-ora
left a comment
dholmes-ora
left a comment
There was a problem hiding this comment.
Seems reasonable. Can't comment on the GHA part though. One query below.
| AC_ARG_ENABLE(deprecated-ports, [AS_HELP_STRING([--enable-deprecated-ports@<:@=yes/no@:>@], | ||
| [Suppress the error when configuring for a deprecated port @<:@no@:>@])]) | ||
| # There are no deprecated ports. Implement the deprecation warnings here. | ||
| if test "x$OPENJDK_TARGET_OS" = xmacosx && test "x$OPENJDK_TARGET_CPU" = xx86_64; then |
There was a problem hiding this comment.
Do we need to exclude zero here the way we did for 32-bit x86?
There was a problem hiding this comment.
Probably.
That said, I am not sure MacOS/x86/Zero even builds. Most if not all Zero builds we realistically use are on Linux. Maybe there is enough of BSD glue to make it build, though. @vidmik, try --with-jvm-variants=zero on MacOS x86, does it even work?
erikj79
left a comment
erikj79
left a comment
There was a problem hiding this comment.
I think this looks good, but would appreciate further input on GHA and impact on zero if there are any concerns there.
shipilev
left a comment
shipilev
left a comment
There was a problem hiding this comment.
In particular, I could use your help making sure the change to GHA (main.yml) does the right thing. The intention is to allow running macOS/x64 builds/tests, but to not include the port by default.
Yes, that looks fine. If you look at https://github.com/vidmik/jdk/actions/runs/28200737215/job/83539333717 run, you can see that MacOS x86 is now excluded along with Alpine Linux x86.
| AC_ARG_ENABLE(deprecated-ports, [AS_HELP_STRING([--enable-deprecated-ports@<:@=yes/no@:>@], | ||
| [Suppress the error when configuring for a deprecated port @<:@no@:>@])]) | ||
| # There are no deprecated ports. Implement the deprecation warnings here. | ||
| if test "x$OPENJDK_TARGET_OS" = xmacosx && test "x$OPENJDK_TARGET_CPU" = xx86_64; then |
There was a problem hiding this comment.
Probably.
That said, I am not sure MacOS/x86/Zero even builds. Most if not all Zero builds we realistically use are on Linux. Maybe there is enough of BSD glue to make it build, though. @vidmik, try --with-jvm-variants=zero on MacOS x86, does it even work?
4 participants
Implementation of the JEP to deprecate the macOS/x64 port for removal. Note that the JEP is still in Submitted state. Meanwhile, I'm opening this PR for awareness and for your help reviewing the proposed changes.
In particular, I could use your help making sure the change to GHA (
main.yml) does the right thing. The intention is to allow running macOS/x64 builds/tests, but to not include the port by default.Progress
Integration blocker
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31684/head:pull/31684$ git checkout pull/31684Update a local copy of the PR:
$ git checkout pull/31684$ git pull https://git.openjdk.org/jdk.git pull/31684/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31684View PR using the GUI difftool:
$ git pr show -t 31684Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31684.diff
Using Webrev
Link to Webrev Comment