done return was being discarded with _. Fixed to capture done and fail the benchmark if !done, even when err == nil.

Author: copejon

deps/github.com/openshift/kubernetes/pkg/registry/rbac/rest/storage_rbac_test.go

@@ -35,8 +35,9 @@ func BenchmarkEnsureRBACPolicy(b *testing.B) {
 			ClusterRoleBindingsToSplit: bootstrappolicy.ClusterRoleBindingsToSplit(),
 		}
 		coreClientSet := fake.NewSimpleClientset()
-		if _, err := ensureRBACPolicy(context.Background(), policy, coreClientSet); err != nil {
-			b.Fatalf("ensureRBACPolicy failed: %v", err)
+		done, err := ensureRBACPolicy(context.Background(), policy, coreClientSet)
+		if err != nil || !done {
+			b.Fatalf("ensureRBACPolicy failed or did not complete: done=%v err=%v", done, err)
 		}
 	}
 }