Gallery app contains invalid usage of rect

[jhrdt]

Hi,

the signature for the rect method requires 4 floats (x, y, w, h).

Two method calls use 5 args:

• badger2350/firmware/apps/gallery/__init__.py

  Line 138 in d37e3b8

  (screen.width / 2) - (width / 2) - 8, 1, width + 16, 17, 6))

• badger2350/firmware/apps/gallery/__init__.py

  Line 141 in d37e3b8

  (screen.width / 2) - (width / 2) - 8, 1, width + 16, 17, 6).stroke(1))

Removing ,1, the last arg solved the problem for me.

I will create a pull request as a follow up to this ticket.

[micahcowan]

I feel like this should be prioritized a bit higher... currently the gallery app in firmware 2.0.2 just crashes on (attempted) open, due to this number-of-args mismatch (probably due to changes to modules/c/picovector/micropython/shape.cpp in rev 44aa2e1. It'd be great to have a firmware release that's both up-to-date, and functioning!

[Gadgetoid]

Should be fixed in v3.0.0!