Type jitter comparison bounds

stephanos · stephanos · commit 17834ddb8d4b · 2026-06-21T13:37:55.000-07:00
diff --git a/common/backoff/jitter_test.go b/common/backoff/jitter_test.go
@@ -34,7 +34,7 @@ func (s *jitterSuite) TestJitter_Int64() {
 		s.Less(result, upperBound)
 
 		result = FullJitter(input)
-		s.GreaterOrEqual(result, 0)
+		s.GreaterOrEqual(result, int64(0))
 		s.Less(result, input)
 	}
 }
@@ -51,7 +51,7 @@ func (s *jitterSuite) TestJitter_Float64() {
 		s.Less(result, upperBound)
 
 		result = FullJitter(input)
-		s.GreaterOrEqual(result, 0)
+		s.GreaterOrEqual(result, float64(0))
 		s.Less(result, input)
 	}
 }
@@ -68,7 +68,7 @@ func (s *jitterSuite) TestJitter_Duration() {
 		s.Less(result, upperBound)
 
 		result = FullJitter(input)
-		s.GreaterOrEqual(result, 0)
+		s.GreaterOrEqual(result, time.Duration(0))
 		s.Less(result, input)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ func (s *jitterSuite) TestJitter_Int64() {`
`34`	`34`	`s.Less(result, upperBound)`
`35`	`35`
`36`	`36`	`result = FullJitter(input)`
`37`		`- s.GreaterOrEqual(result, 0)`
	`37`	`+ s.GreaterOrEqual(result, int64(0))`
`38`	`38`	`s.Less(result, input)`
`39`	`39`	`}`
`40`	`40`	`}`
`@@ -51,7 +51,7 @@ func (s *jitterSuite) TestJitter_Float64() {`
`51`	`51`	`s.Less(result, upperBound)`
`52`	`52`
`53`	`53`	`result = FullJitter(input)`
`54`		`- s.GreaterOrEqual(result, 0)`
	`54`	`+ s.GreaterOrEqual(result, float64(0))`
`55`	`55`	`s.Less(result, input)`
`56`	`56`	`}`
`57`	`57`	`}`
`@@ -68,7 +68,7 @@ func (s *jitterSuite) TestJitter_Duration() {`
`68`	`68`	`s.Less(result, upperBound)`
`69`	`69`
`70`	`70`	`result = FullJitter(input)`
`71`		`- s.GreaterOrEqual(result, 0)`
	`71`	`+ s.GreaterOrEqual(result, time.Duration(0))`
`72`	`72`	`s.Less(result, input)`
`73`	`73`	`}`
`74`	`74`	`}`