Dynamic partitioning: add functional tests and fix background timer#10776
Merged
Conversation
dnr
changed the title
carlydf
approved these changes
Jun 24, 2026
carlydf
left a comment
carlydf
left a comment
Contributor
There was a problem hiding this comment.
nit: could you mention the timer reset fix in the title so when we look back it's easy to tell that this had more than just test changes?
Contributor
Author
yes! sorry I forgot that |
dnr
changed the title
stephanos
pushed a commit
that referenced
this pull request
Jun 25, 2026
…10776) ## What changed? - Fix background timer: it was effectively resetting the timer when an add batch came in. Now it always does the background work periodically regardless of add batches. - Add functional tests for dynamic partition scaling. ## Why? Make sure it works, make sure drain check happens periodically. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Make sure it works, make sure drain check happens periodically.
How did you test it?