Implement --noheadings for lsns#569
Open
vbmade2000 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Malhar Vora <mlvora.2010@gmail.com>
Signed-off-by: Malhar Vora <mlvora.2010@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
===========================
===========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Alonely0
reviewed
Jun 29, 2026
Alonely0
left a comment
Alonely0
left a comment
There was a problem hiding this comment.
Looks great; just a nitpick from my end.
| read_namespaces(&mut lsns)?; | ||
|
|
||
| display_namespaces(&lsns)?; | ||
| display_namespaces(&lsns, noheadings)?; |
There was a problem hiding this comment.
I would move this flag into the Lsns struct, like all the other ones. This allows for reproducible behavior of the util through that struct alone, as well as preventing function args from getting out of hand. Should also make the diff smaller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #567