Ensure that the Maven plugin configuration keeps working

The Maven Plugin was using the core ModuleDependency type as part of its configuration, which requires that the type has a zero-argument constructor. When this constructor was removed it broke the Maven Plugin configuration. This commit adds a type directly to the Maven Plugin, ensuring that the future evolution of ModuleDependency does not break the Maven Plugin and vice-versa

Fixes #1140

Signed-off-by: Tim Ward <timothyjward@apache.org>

Author: timothyjward

typescript-generator-maven-plugin/src/main/java/cz/habarta/typescript/generator/maven/GenerateMojo.java

@@ -13,7 +13,6 @@
 import cz.habarta.typescript.generator.JsonbConfiguration;
 import cz.habarta.typescript.generator.Logger;
 import cz.habarta.typescript.generator.MapMapping;
-import cz.habarta.typescript.generator.ModuleDependency;
 import cz.habarta.typescript.generator.NullabilityDefinition;
 import cz.habarta.typescript.generator.OptionalProperties;
 import cz.habarta.typescript.generator.OptionalPropertiesDeclaration;
@@ -30,6 +29,7 @@
 import java.net.URLClassLoader;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Optional;
 import org.apache.maven.artifact.DependencyResolutionRequiredException;
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugins.annotations.LifecyclePhase;
@@ -900,7 +900,13 @@ private Settings createSettings(URLClassLoader classLoader) {
         settings.namespace = namespace;
         settings.mapPackagesToNamespaces = mapPackagesToNamespaces;
         settings.umdNamespace = umdNamespace;
-        settings.moduleDependencies = moduleDependencies;
+        settings.moduleDependencies = Optional.ofNullable(moduleDependencies)
+                .map(list -> list.stream().map(md -> {
+                	return new cz.habarta.typescript.generator.ModuleDependency(false,
+                		md.importFrom, md.importAs, md.infoJson, md.npmPackageName, md.npmVersionRange,
+                		md.npmPackageName != null);
+                	}).toList())
+                .orElse(List.of());
         settings.setExcludeFilter(excludeClasses, excludeClassPatterns);
         settings.jsonLibrary = jsonLibrary;
         settings.setJackson2Configuration(classLoader, jackson2Configuration);

typescript-generator-maven-plugin/src/main/java/cz/habarta/typescript/generator/maven/ModuleDependency.java

@@ -0,0 +1,29 @@
+
+package cz.habarta.typescript.generator.maven;
+
+import cz.habarta.typescript.generator.util.Utils;
+import java.io.File;
+import org.jspecify.annotations.Nullable;
+
+/**
+ * A simple data class representing a module dependency for the TypeScript
+ * generator Maven plugin. It decouples the ModuleDependency class from the core 
+ * TypeScript generator library, allowing foreasier maintenance and potential future
+ * changes in the core library without being limited by the Maven plugin's requirements.
+ */
+public class ModuleDependency {
+	@SuppressWarnings("NullAway.Init")
+    public String importFrom;
+	@SuppressWarnings("NullAway.Init")
+    public String importAs;
+	@SuppressWarnings("NullAway.Init")
+    public File infoJson;
+    public @Nullable String npmPackageName;
+    public @Nullable String npmVersionRange;
+
+    @Override
+    public String toString() {
+        return Utils.objectToString(this);
+    }
+
+}