Skip to content

Commit f27100b

Browse files
vmassolKimi Code
andcommitted
[Misc] Fix expected/actual argument order in assertions (SonarQube java:S3415)
Co-Authored-By: Kimi Code <noreply@moonshot.cn>
1 parent 9d3f3d4 commit f27100b

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

  • xwiki-commons-core
    • xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/event
    • xwiki-commons-store/xwiki-commons-store-blob/xwiki-commons-store-blob-filesystem/src/test/java/org/xwiki/store/blob/internal

xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/test/java/org/xwiki/logging/event/LogEventTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,19 @@ void testGetMessageElements()
4040
{
4141
LogEvent logEvent = new LogEvent(null, LogLevel.ERROR, "", null, null);
4242

43-
assertEquals(logEvent.getMessageElements(), Arrays.asList(""));
43+
assertEquals(Arrays.asList(""), logEvent.getMessageElements());
4444

4545
logEvent = new LogEvent(null, LogLevel.ERROR, "", ArrayUtils.EMPTY_OBJECT_ARRAY, null);
4646

47-
assertEquals(logEvent.getMessageElements(), Arrays.asList(""));
47+
assertEquals(Arrays.asList(""), logEvent.getMessageElements());
4848

4949
logEvent = new LogEvent(null, LogLevel.ERROR, "message", ArrayUtils.EMPTY_OBJECT_ARRAY, null);
5050

51-
assertEquals(logEvent.getMessageElements(), Arrays.asList("message"));
51+
assertEquals(Arrays.asList("message"), logEvent.getMessageElements());
5252

5353
logEvent = new LogEvent(null, LogLevel.ERROR, "message {}", new Object[]{ "" }, null);
5454

55-
assertEquals(logEvent.getMessageElements(), Arrays.asList("message ", ""));
55+
assertEquals(Arrays.asList("message ", ""), logEvent.getMessageElements());
5656
}
5757

5858
@Test
@@ -64,6 +64,6 @@ void testLogLogger()
6464

6565
logEvent.log(queue);
6666

67-
assertEquals(logEvent.getMessage(), "message");
67+
assertEquals("message", logEvent.getMessage());
6868
}
6969
}

xwiki-commons-core/xwiki-commons-store/xwiki-commons-store-blob/xwiki-commons-store-blob-filesystem/src/test/java/org/xwiki/store/blob/internal/FileSystemBlobStoreTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -749,8 +749,8 @@ void equalsAndHashCode()
749749
assertNotEquals(store1.hashCode(), store3.hashCode());
750750

751751
// Not equals to null or different type
752-
assertNotEquals(store1, null);
753-
assertNotEquals(store1, "string");
752+
assertNotEquals(null, store1);
753+
assertNotEquals("string", store1);
754754

755755
// Self equality
756756
assertEquals(store1, store1);

0 commit comments

Comments
 (0)