Dev#12
Merged
Merged
Conversation
No linter was configured in this repo. Added ruff as a dev dependency with a project ruleset (E, F, W, I) and a dedicated lint job in ci.yml. dashboard.py is excluded from line-length checks since it embeds the dashboard-ui HTML/JS as a Python string (auto-synced, not hand-written).
Import ordering (unsorted-imports), a couple of unused imports/variables in tests, an unaligned if/elif chain in aggregator.py, and several lines over 100 chars wrapped without behavior changes. 83/83 tests still pass.
Matches the saas-api header rename (CDC section 8.4.1). Breaking change for cloud mode users — must ship together with the saas-api and other SDKs' companion renames. Verified end-to-end: CloudTransport.write_routes() against a local saas-api test instance registers the route correctly with the new header. 83/83 tests still pass.
…Delivr The local dashboard downloaded its React/Babel runtime from a CDN on first launch, breaking the local- and privacy-first promise. Bundle the minified UMD builds inside the package (react 18.3.1, react-dom 18.3.1, @babel/standalone 7.29.7 — matching the Node SDK) and serve them locally. No third-party request is made; the dashboard works fully offline.
The internal `_flush_interval` kwarg was reachable through the public middleware constructor. Clamp it to a 60s floor so no caller can shorten the send cadence below the intended cadence. The kwarg stays internal for the test suite, which passes larger values.
Ship the breaking cloud header rename (X-API-Key -> X-APIForge-Key) and the vendored dashboard assets. Registry versions 3.x send the old header and are rejected with 401 by the current API; 4.0.0 is required for cloud mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
Related issue
Closes #
Changes
Testing
Checklist
CHANGELOG.md