Skip to content

[PWGCF] change QA plot range#16931

Open
blacwovie wants to merge 4 commits into
AliceO2Group:masterfrom
blacwovie:master
Open

[PWGCF] change QA plot range#16931
blacwovie wants to merge 4 commits into
AliceO2Group:masterfrom
blacwovie:master

Conversation

@blacwovie

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 27 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title change QA plot range [PWGCF] change QA plot range Jul 6, 2026
@blacwovie blacwovie marked this pull request as ready for review July 6, 2026 12:42
@alibuild

alibuild commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 798d8eb at 2026-07-06 14:54:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 29 errors and 8 warnings.'
Found 29 errors and 8 warnings.
++ [[ 29 -gt 0 ]]
++ cat /sw/BUILD/b08136d7ec546e0a80ca4d526f62036b92a0c9d8/O2Physics-code-check/errors.txt
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:19:1: error: included header FemtoWorldMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:82:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:85:39: error: 'betheBlochParticleNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:86:39: error: 'betheBlochParNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:87:39: error: 'tmpRadiiTPC' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:103:7: error: variable 'MassHad' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:109:3: error: function 'recoPtNu' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:110:3: error: function 'recoPhiNu' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:111:3: error: function 'recoEtaNu' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:112:3: error: function 'recoPtHad' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:113:3: error: function 'recoPhiHad' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:114:3: error: function 'recoEtaHad' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:173:8: error: constructor does not initialize these fields: mCcdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:248:90: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:427:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:428:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:502:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:534:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:576:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:604:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:654:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:851:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:968:11: error: variable 'tpcNSigmaDe' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:1004:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:1080:11: error: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:1109:23: error: no header providing "ROOT::Math::PxPyPzMVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:1121:23: error: no header providing "ROOT::Math::Boost" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:1663:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:1695:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/b08136d7ec546e0a80ca4d526f62036b92a0c9d8/O2Physics-code-check/warnings.txt
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:817:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:821:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:825:130: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:829:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:831:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:977:102: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:985:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:1372:13: warning: 1st argument 'track0' (passed to 'track1') looks like it might be swapped with the 2nd, 'track1' (passed to 'track2') [readability-suspicious-call-argument]
++ [[ 29 -gt 0 ]]
++ exit 1
--
[0 more errors; see full log]

Full log here.

@blacwovie blacwovie marked this pull request as draft July 6, 2026 12:55
@blacwovie blacwovie marked this pull request as ready for review July 6, 2026 13:17
@alibuild

alibuild commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0455ebe at 2026-07-06 15:42:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 0 warnings.'
Found 4 errors and 0 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/6b9669be14f10eed72233e435ea2495e09ca7f9b/O2Physics-code-check/errors.txt
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:57:1: error: included header Boost.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:58:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:1097:23: error: no header providing "ROOT::Math::PxPyPzMVector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/FemtoNuclei/TableProducer/HadNucleiFemto.cxx:1109:23: error: no header providing "ROOT::Math::Boost" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

@blacwovie blacwovie marked this pull request as draft July 6, 2026 13:50
@blacwovie blacwovie marked this pull request as ready for review July 6, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants