Skip to content

[PWGLF] Fix of the mirroring in hStrangeCorrelation.cxx#16952

Merged
romainschotter merged 1 commit into
AliceO2Group:masterfrom
lhusova:hStrFixMirroring
Jul 7, 2026
Merged

[PWGLF] Fix of the mirroring in hStrangeCorrelation.cxx#16952
romainschotter merged 1 commit into
AliceO2Group:masterfrom
lhusova:hStrFixMirroring

Conversation

@lhusova

@lhusova lhusova commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

fix the mirroring

@github-actions github-actions Bot added the pwglf label Jul 7, 2026
@github-actions github-actions Bot changed the title Fix of the mirroring in hStrangeCorrelation.cxx [PWGLF] Fix of the mirroring in hStrangeCorrelation.cxx Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 8 errors, ⚠️ 0 warnings, 🔕 0 disabled

@romainschotter romainschotter enabled auto-merge (squash) July 7, 2026 15:06
@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b46df15 at 2026-07-07 17:21:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 200 errors and 232 warnings.'
Found 200 errors and 232 warnings.
++ [[ 200 -gt 0 ]]
++ cat /sw/BUILD/96f560a0e90233bc9803f97cbd280dc88717a6f2/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:87:8: error: constructor does not initialize these fields: ccdb, pdgDB, hEfficiencyTrigger, hEfficiencyTriggerMult, hEfficiencyTriggerMultVsPhi, hEfficiencyPion, hEfficiencyK0Short, hEfficiencyK0ShortMultVsPhi, hEfficiencyLambda, hEfficiencyLambdaMultVsPhi, hEfficiencyAntiLambda, hEfficiencyAntiLambdaMultVsPhi, hEfficiencyXiMinus, hEfficiencyXiMinusMultVsPhi, hEfficiencyXiPlus, hEfficiencyXiPlusMultVsPhi, hEfficiencyOmegaMinus, hEfficiencyOmegaMinusMultVsPhi, hEfficiencyOmegaPlus, hEfficiencyOmegaPlusMultVsPhi, hEfficiencyHadron, hEfficiencyHadronMult, hPurityHadron, hPurityHadronMult, hEfficiencyUncertaintyTrigger, hEfficiencyUncertaintyTriggerMult, hEfficiencyUncertaintyPion, hEfficiencyUncertaintyK0Short, hEfficiencyUncertaintyLambda, hEfficiencyUncertaintyAntiLambda, hEfficiencyUncertaintyXiMinus, hEfficiencyUncertaintyXiPlus, hEfficiencyUncertaintyOmegaMinus, hEfficiencyUncertaintyOmegaPlus, hEfficiencyUncertaintyHadron, hEfficiencyUncertaintyHadronMult, hPurityUncertaintyHadron, hPurityUncertaintyHadronMult, doCorrelation, mRunNumber, mRunNumberZorro [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:290:10: error: constructor does not initialize these fields: pvz, mult [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:306:29: error: use designated initializer list to initialize 'ValidParticle' [modernize-use-designated-initializers,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:369:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:370:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:371:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:372:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:389:15: error: member 'ctauxi' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:390:15: error: member 'ctauomega' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:435:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:441:26: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:442:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:443:35: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:444:26: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:445:35: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:446:25: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:447:34: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:448:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:449:38: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:450:26: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:451:35: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:452:25: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:453:34: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:454:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:455:38: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:456:28: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:457:37: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:458:25: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:459:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:460:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:461:21: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:462:25: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:463:37: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:464:41: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:465:37: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:466:36: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:467:40: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:468:37: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:469:36: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:470:40: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:471:39: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:472:34: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@romainschotter romainschotter merged commit b39849c into AliceO2Group:master Jul 7, 2026
12 of 16 checks passed
@vkucera

vkucera commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

@romainschotter What is the strategy for fixing the bugs and other errors and warnings?

mcoquet642 pushed a commit to AliceMCH/O2Physics that referenced this pull request Jul 9, 2026
…#16952)

Co-authored-by: Lucia Anna Tarasovicova <lucia.anna.husova@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants