fix: keep deployments successful when verification fails

src/ape/api/accounts.py

@@ -379,7 +379,10 @@ def deploy(
 
         if publish:
             self.local_project.deployments.track(instance)
-            self.provider.network.publish_contract(address)
+            try:
+                self.provider.network.publish_contract(address)
+            except Exception as err:
+                logger.error(f"Contract was deployed but explorer verification failed: {err}")
 
         instance.base_path = contract.base_path or self.local_project.path
         return instance

src/ape/contracts/base.py

@@ -1701,7 +1701,10 @@ def deploy(self, *args, publish: bool = False, **kwargs) -> ContractInstance:
 
         if publish:
             self.local_project.deployments.track(instance)
-            self.provider.network.publish_contract(address)
+            try:
+                self.provider.network.publish_contract(address)
+            except Exception as err:
+                logger.error(f"Contract was deployed but explorer verification failed: {err}")
 
         instance.base_path = self.base_path or self.local_project.contracts_folder
         return instance

tests/functional/test_accounts.py

@@ -17,7 +17,6 @@
     AliasAlreadyInUseError,
     MethodNonPayableError,
     MissingDeploymentBytecodeError,
-    NetworkError,
     ProjectError,
     SignatureError,
 )
@@ -337,12 +336,13 @@ def test_deploy_and_publish_local_network(owner, minimal_proxy_container):
 
 @explorer_test
 def test_deploy_and_publish_live_network_no_explorer(
-    owner, minimal_proxy_container, dummy_live_network
+    owner, minimal_proxy_container, dummy_live_network, ape_caplog
 ):
     dummy_live_network.__dict__["explorer"] = None
     expected_message = "Unable to publish contract - no explorer plugin installed."
-    with pytest.raises(NetworkError, match=expected_message):
-        owner.deploy(minimal_proxy_container, publish=True, required_confirmations=0)
+    contract = owner.deploy(minimal_proxy_container, publish=True, required_confirmations=0)
+    assert contract.address
+    assert expected_message in ape_caplog.head
 
 
 @explorer_test
@@ -353,6 +353,23 @@ def test_deploy_and_publish(
     mock_explorer.publish_contract.assert_called_once_with(contract.address)
 
 
+@explorer_test
+def test_deploy_and_publish_explorer_failure(
+    owner,
+    minimal_proxy_container,
+    dummy_live_network_with_explorer,
+    mock_explorer,
+    ape_caplog,
+):
+    mock_explorer.publish_contract.side_effect = RuntimeError("Verification failed.")
+    contract = owner.deploy(minimal_proxy_container, publish=True, required_confirmations=0)
+    assert contract.address
+    assert (
+        "Contract was deployed but explorer verification failed: Verification failed."
+        in ape_caplog.head
+    )
+
+
 @explorer_test
 def test_deploy_and_not_publish(
     owner, minimal_proxy_container, dummy_live_network_with_explorer, mock_explorer

tests/functional/test_contract_container.py

@@ -7,7 +7,6 @@
     ArgumentsLengthError,
     MethodNonPayableError,
     MissingDeploymentBytecodeError,
-    NetworkError,
     ProjectError,
 )
 from ape_ethereum.ecosystem import ProxyType
@@ -51,12 +50,13 @@ def test_deploy_and_publish_local_network(owner, minimal_proxy_container):
 
 
 def test_deploy_and_publish_live_network_no_explorer(
-    owner, minimal_proxy_container, dummy_live_network
+    owner, minimal_proxy_container, dummy_live_network, ape_caplog
 ):
     dummy_live_network.__dict__["explorer"] = None
     expected_message = "Unable to publish contract - no explorer plugin installed."
-    with pytest.raises(NetworkError, match=expected_message):
-        minimal_proxy_container.deploy(sender=owner, publish=True, required_confirmations=0)
+    contract = minimal_proxy_container.deploy(sender=owner, publish=True, required_confirmations=0)
+    assert contract.address
+    assert expected_message in ape_caplog.head
 
 
 @explorer_test
@@ -67,6 +67,23 @@ def test_deploy_and_publish(
     mock_explorer.publish_contract.assert_called_once_with(contract.address)
 
 
+@explorer_test
+def test_deploy_and_publish_explorer_failure(
+    owner,
+    minimal_proxy_container,
+    dummy_live_network_with_explorer,
+    mock_explorer,
+    ape_caplog,
+):
+    mock_explorer.publish_contract.side_effect = RuntimeError("Verification failed.")
+    contract = minimal_proxy_container.deploy(sender=owner, publish=True, required_confirmations=0)
+    assert contract.address
+    assert (
+        "Contract was deployed but explorer verification failed: Verification failed."
+        in ape_caplog.head
+    )
+
+
 @explorer_test
 def test_deploy_and_not_publish(
     owner, minimal_proxy_container, dummy_live_network_with_explorer, mock_explorer