Skip to content

Normalize percent-encoding hex case in SHR p-claim validation - #3559

Closed
debchoudhury-id4s wants to merge 1 commit into
AzureAD:devfrom
debchoudhury-id4s:workitem-3699975-shr-p-claim-percent-encoding
Closed

Normalize percent-encoding hex case in SHR p-claim validation#3559
debchoudhury-id4s wants to merge 1 commit into
AzureAD:devfrom
debchoudhury-id4s:workitem-3699975-shr-p-claim-percent-encoding

Conversation

@debchoudhury-id4s

Copy link
Copy Markdown
Contributor

Summary

  • normalize ASCII hexadecimal letter casing inside valid %XX triplets during Signed HTTP Request p claim validation
  • preserve literal path-case behavior through UseCaseSensitivePClaimComparison, slash tolerance, encoded delimiters, and unchanged p claim creation output
  • add validation and creation compatibility coverage and document the validation-only change

Testing

  • dotnet clean Wilson.sln -c Debug
  • dotnet build Wilson.sln -c Debug (0 warnings, 0 errors)
  • dotnet test Wilson.sln -c Debug --no-build (21,813 passed, 8 skipped, 0 failed across net6.0/net8.0/net9.0/net10.0)
  • focused PClaim tests passed on net6.0, net8.0, net9.0, and net10.0
  • net462/net472 builds succeeded locally, but test execution requires the repository strong-name bypass configured in CI

Work item: https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3699975/
AB#3699975

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@debchoudhury-id4s
debchoudhury-id4s requested a review from a team as a code owner July 23, 2026 20:03
@debchoudhury-id4s

Copy link
Copy Markdown
Contributor Author

Superseded by #3561, which uses an AzureAD-owned source branch consistent with this repository's PR strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant