Skip to content

Improve lobby sleeve icon downscaling #10952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MostCromulent wants to merge 3 commits into
base: master
Choose a base branch
from
+20 −1
Open

Improve lobby sleeve icon downscaling #10952

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8fb521
Sharpen lobby sleeve icon with high-quality downscale
MostCromulent Jun 10, 2026
ed8911d
Sharpen large downscaled background icons in FLabel
MostCromulent Jun 11, 2026
eb290b7
Merge branch 'master' of https://github.com/Card-Forge/forge into lob…
MostCromulent Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions forge-gui-desktop/src/main/java/forge/screens/home/PlayerPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ void update() {
avatarLabel.repaintSelf();

sleeveLabel.setEnabled(mayEdit);
sleeveLabel.setIcon(FSkin.getSleeves().get(type == LobbySlotType.OPEN ? -1 : sleeveIndex));
setSleeveIcon(FSkin.getSleeves().get(type == LobbySlotType.OPEN ? -1 : sleeveIndex));
sleeveLabel.repaintSelf();

txtPlayerName.setEnabled(mayEdit);
Expand Down Expand Up @@ -699,7 +699,7 @@ private void createSleeve() {
final String[] currentPrefs = FModel.getPreferences().getPref(FPref.UI_SLEEVES).split(",");
if (index < currentPrefs.length) {
sleeveIndex = Integer.parseInt(currentPrefs[index]);
sleeveLabel.setIcon(FSkin.getSleeves().get(sleeveIndex));
setSleeveIcon(FSkin.getSleeves().get(sleeveIndex));
} else {
setRandomSleeve(false);
}
Expand Down Expand Up @@ -805,11 +805,15 @@ public int getSleeveIndex() {
}
public void setSleeveIndex(final int sleeveIndex0) {
sleeveIndex = sleeveIndex0;
final SkinImage icon = FSkin.getSleeves().get(sleeveIndex);
sleeveLabel.setIcon(icon);
setSleeveIcon(FSkin.getSleeves().get(sleeveIndex));
sleeveLabel.repaintSelf();
}

// Scaling the full-size source straight to this small label looks rough; pre-scale once at 2x for HiDPI headroom
private void setSleeveIcon(final SkinImage icon) {
sleeveLabel.setIcon(icon == null ? null : icon.resize(58 * 2, 80 * 2));
}

public int getTeam() {
return teamComboBox.getSelectedIndex();
}
Expand Down
Loading