feat: bump go-runner to 1.2.1#421
Conversation
Update DEFAULT_GO_RUNNER_VERSION to 1.2.1 and add the matching SHA-256-pinned installer row to the GO_RUNNER_INSTALLER_SHA256S table. The pinned hash is verified by `cargo test all_pinned`. Refs COD-2990 Co-Authored-By: Claude <noreply@anthropic.com>
Explain that pinned hashes live in two places (src/binary_pins.rs and the go-runner table in go.sh), and document getting the SHA-256 from the `cargo test all_pinned` failure output instead of computing it by hand. Co-Authored-By: Claude <noreply@anthropic.com>
Greptile SummaryBumps the default codspeed-go runner to
Confidence Score: 5/5Safe to merge — the change is a two-line data update (new table row + default version bump) with no logic modifications, and the hash was validated by the all_pinned test suite. The go.sh change only appends a row to the SHA-256 lookup table and updates the default pointer; the verification path (lookup → download → hash comparison → execute) is unchanged. The 64-character hash is well-formed, the PR description confirms the test passed locally, and CI runs the same test. The CONTRIBUTING.md edits are purely documentation. No files require special attention. Important Files Changed
|
Merging this PR will not alter performance
|
Bump the default codspeed-go runner to
1.2.1and pin its installer SHA-256.This updates
DEFAULT_GO_RUNNER_VERSIONand adds the matching<version> <sha256>row to theGO_RUNNER_INSTALLER_SHA256Stable ingo.sh. The pinned hash is verified byGITHUB_ACTIONS=true cargo test all_pinned, which passed locally.Also documents the two-location pinning setup (
src/binary_pins.rsand thego-runner table) in
CONTRIBUTING.md, and the test-driven workflow for gettinga new hash from the verification-test failure rather than computing it by hand.
Refsrather thanCloses: this PR is the prerequisite bump — the 4.18.1runner release (the
cargo releasetag) is the follow-up step that resolves theissue.
Refs COD-2990