[DET-109][jobs] inject ol_env into ol spark run tags#11786
Draft
ajyu wants to merge 1 commit into
Draft
Conversation
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DET-109
Adds
_dd.ol_env:<env>to thespark.openlineage.run.tagsset insetupOpenLineage, alongside the existing_dd.ol_service/_dd.ol_app_id.The value comes from
Config.get().getEnv(), and the tag is omitted when envis empty.
Motivation
Downstream (dd-source
lineage-processor) uses the run environment as theSpark application UGP node's
namespace. A node'sentity_idishash(name, type, namespace); today the OpenLineage path and the tracer-onlypath (
djm-span-processor) derivenamespacedifferently, so the same Sparkapplication resolves to two different entities. Carrying env here lets both
paths key the namespace off the same value (env) and converge on one
entity_id._dd.ol_servicealready aligns name; this aligns namespace.When env is unset the tag is omitted so the consumer falls back to the
OpenLineage namespace (no empty-namespace).
Additional Notes
setupOpenLineagetests assert via.contains(...), so the new tagdoesn't affect them; added a test asserting
_dd.ol_env:<env>is present whendd.envis set.