Add direct coverage tests for Hashtable.D2.Entry#11794
Open
dougqh wants to merge 1 commit into
Open
Conversation
Tests matches() with both true and false branches, and hash() for consistency and key-sensitivity, since existing D2 operation tests don't guarantee the false branch fires (different key pairs hash to different buckets, so matches() is never called with a mismatch). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dougqh
added
tag: flaky test
dd-octo-sts
Bot
added
the
tag: ai generated
bric3
approved these changes
Jun 29, 2026
Contributor
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
D2.Entry.matches()(true and false branches) andD2.Entry.hash()toHashtableD2Testmatches()indirectly, but the false branch is not guaranteed to fire since different key pairs typically hash to different bucketsMotivation
Code coverage
tag: no release note
tag: ai generated
🤖 Generated with Claude Code