Skip to content

fix(metrics): prevent 500 on Critical Asset Metrics page when no critical products exist #15057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentijnscholten wants to merge 2 commits into
base: bugfix
Choose a base branch
from
+9 −4
Open

fix(metrics): prevent 500 on Critical Asset Metrics page when no critical products exist #15057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad91f8e
fix(metrics): prevent 500 on Critical Asset Metrics page when no crit…
valentijnscholten Jun 22, 2026
fa3cf5d
test(e2e): smoke-check /critical_asset_metrics page loads (#15051)
valentijnscholten Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dojo/templates/dojo/metrics.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ <h3 id="accepted-per-month-title">{% trans "Risk accepted bug count by month" %}
<!-- /.panel -->
</div>
{% endif %}
{% if not critical_prods %}
{% if not critical_prods and name != labels.ASSET_METRICS_CRITICAL_LABEL %}
<div class="col-lg-12">
<div class="panel panel-default">
<div class="panel-heading">
Expand Down Expand Up @@ -943,7 +943,7 @@ <h4>{% trans "Closed in Period" %}</h4>
medium1.push([{{ week.epoch }}, {{ week.medium }}]);
low1.push([{{ week.epoch }}, {{ week.low }}]);
{% endfor %}
{% if not critical_prods %}
{% if not critical_prods and name != labels.ASSET_METRICS_CRITICAL_LABEL %}
opened_per_week_2(critical, high, medium, low);
accepted_per_week_2(critical1, high1, medium1, low1);
{% endif %}
Expand Down
4 changes: 2 additions & 2 deletions dojo/templates_classic/dojo/metrics.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ <h3 id="accepted-per-month-title">{% trans "Risk accepted bug count by month" %}
<!-- /.panel -->
</div>
{% endif %}
{% if not critical_prods %}
{% if not critical_prods and name != labels.ASSET_METRICS_CRITICAL_LABEL %}
<div class="col-lg-12">
<div class="panel panel-default">
<div class="panel-heading">
Expand Down Expand Up @@ -958,7 +958,7 @@ <h4>{% trans "Closed in Period" %}</h4>
medium1.push([{{ week.epoch }}, {{ week.medium }}]);
low1.push([{{ week.epoch }}, {{ week.low }}]);
{% endfor %}
{% if not critical_prods %}
{% if not critical_prods and name != labels.ASSET_METRICS_CRITICAL_LABEL %}
opened_per_week_2(critical, high, medium, low);
accepted_per_week_2(critical1, high1, medium1, low1);
{% endif %}
Expand Down
5 changes: 5 additions & 0 deletions tests/check_various_pages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ def test_user_status(self):
driver = self.driver
driver.get(self.base_url + "user")

def test_critical_asset_metrics_status(self):
driver = self.driver
driver.get(self.base_url + "critical_asset_metrics")

def test_calendar_status(self):
driver = self.driver
driver.get(self.base_url + "calendar")
Expand Down Expand Up @@ -42,6 +46,7 @@ def suite():
suite = unittest.TestSuite()
suite.addTest(BaseTestCase("test_login"))
suite.addTest(VariousPagesTest("test_user_status"))
suite.addTest(VariousPagesTest("test_critical_asset_metrics_status"))
suite.addTest(VariousPagesTest("test_calendar_status"))
suite.addTest(VariousPagesTest("test_finding_group_open_status"))
suite.addTest(VariousPagesTest("test_finding_group_all_status"))
Expand Down
Loading