refactor(dashboard): unify query runner metadata into RunnerInfo#7063
refactor(dashboard): unify query runner metadata into RunnerInfo#7063cckellogg wants to merge 4 commits into
Conversation
Rust Dependency DiffHead: ✅ OK: Within budget.
Added
Removed
|
Greptile SummaryThis PR replaces the Ray-specific
Confidence Score: 4/5Safe to merge; the refactor is internally consistent across all layers and the live-query path is fully correct. The core live-query path from RayRunner through PyQueryMetadata to the dashboard is correctly updated end-to-end. Gaps in event log serialization (distributed and task_events_enabled never written to disk) and the hardcoded import.rs values affect only historical log replay, not live sessions. daft/subscribers/event_log.py (new fields not written to disk) and src/daft-dashboard/src/import.rs (distributed hardcoded to false, task_events_enabled to None) need attention before the event-log import path is fully correct. Important Files Changed
Reviews (2): Last reviewed commit: "fixes" | Re-trigger Greptile |
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7063 +/- ##
==========================================
+ Coverage 75.22% 75.99% +0.76%
==========================================
Files 1148 1153 +5
Lines 161452 163412 +1960
==========================================
+ Hits 121456 124188 +2732
+ Misses 39996 39224 -772
🚀 New features to boost your workflow:
|
Changes Made
Replaces the Ray-specific
ray_dashboard_urlandray_versionfields on query metadata with a single, always-present RunnerInfo struct.This makes
distributedan honest field (false for native) and generalizes the dashboard beyond Ray — the "Open Dashboard" link, version display, and tasks panel now key offrunner.distributedinstead of sniffing the runner string for "Flotilla".