test(ray): give conda-env UDF actor startup more headroom#7096
test(ray): give conda-env UDF actor startup more headroom#7096rohitkulshreshtha wants to merge 1 commit into
Conversation
test_udf_with_conda_inject_dependencies builds a fresh conda env and pip-installs daft at actor startup, which can exceed the default 120s actor_udf_ready_timeout under CI load — surfacing a startup-timeout error instead of the expected 'No module named faker'. Scope the timeout to 300s for this test so the env build has room. Behavior-only timeout bump; no production code change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rust Dependency DiffHead: ✅ OK: Within budget.
|
Greptile SummaryThis PR wraps the entire body of
Confidence Score: 5/5Safe to merge — the change is limited to a single test file and only adds a scoped timeout context around the existing test logic. The context manager correctly scopes the higher timeout to this one test and restores the original config on exit. No production code is touched, no test assertions are altered, and the retry headroom directly targets a real CI flake caused by slow conda env creation. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "test(ray): give conda-env UDF actor star..." | Re-trigger Greptile |
What
test_udf_with_conda_inject_dependenciesbuilds a fresh conda env and pip-installsdaftat actor startup. On shared/loaded CI runners that can exceed the default 120sactor_udf_ready_timeout, so the test intermittently fails withUDF actors failed to start within 120 secondsinstead of the expectedNo module named 'faker'— a flake unrelated to the code under test.Change
Scope
actor_udf_ready_timeoutto 300s for this one test viadaft.execution_config_ctx(...), giving the conda env build headroom. Behavior-only timeout bump — no production code change, and the context manager restores config afterward so other tests are unaffected.