Skip to content

test(ray): give conda-env UDF actor startup more headroom#7096

Open
rohitkulshreshtha wants to merge 1 commit into
mainfrom
rohit/test/conda-udf-timeout
Open

test(ray): give conda-env UDF actor startup more headroom#7096
rohitkulshreshtha wants to merge 1 commit into
mainfrom
rohit/test/conda-udf-timeout

Conversation

@rohitkulshreshtha

Copy link
Copy Markdown
Contributor

What

test_udf_with_conda_inject_dependencies builds a fresh conda env and pip-installs daft at actor startup. On shared/loaded CI runners that can exceed the default 120s actor_udf_ready_timeout, so the test intermittently fails with UDF actors failed to start within 120 seconds instead of the expected No module named 'faker' — a flake unrelated to the code under test.

Change

Scope actor_udf_ready_timeout to 300s for this one test via daft.execution_config_ctx(...), giving the conda env build headroom. Behavior-only timeout bump — no production code change, and the context manager restores config afterward so other tests are unaffected.

test_udf_with_conda_inject_dependencies builds a fresh conda env and
pip-installs daft at actor startup, which can exceed the default 120s
actor_udf_ready_timeout under CI load — surfacing a startup-timeout
error instead of the expected 'No module named faker'. Scope the timeout
to 300s for this test so the env build has room. Behavior-only timeout
bump; no production code change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Rust Dependency Diff

Head: 1fc38636d2b90edfdb50fbc61a90bdd56d07b8f6 vs Base: d48ab2b06f731c8a838a0f022e0c88128605f0c2.

OK: Within budget.

  • New Crates: 0
  • Removed Crates: 0

@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR wraps the entire body of test_udf_with_conda_inject_dependencies in a daft.execution_config_ctx(actor_udf_ready_timeout=300) context manager to give CI runners extra time (300 s vs. the 120 s default) for fresh conda env creation before concluding the test has failed.

  • Scopes the higher timeout to only this one test via the context manager, so no other tests are affected and production config is unchanged.
  • All test logic (the "missing faker" failure assertion and the successful run with faker installed) is preserved inside the context.

Confidence Score: 5/5

Safe to merge — the change is limited to a single test file and only adds a scoped timeout context around the existing test logic.

The context manager correctly scopes the higher timeout to this one test and restores the original config on exit. No production code is touched, no test assertions are altered, and the retry headroom directly targets a real CI flake caused by slow conda env creation.

No files require special attention.

Important Files Changed

Filename Overview
tests/ray/test_udf_ray_options.py Wraps test body in execution_config_ctx to raise actor_udf_ready_timeout to 300s; no logic changes, context manager ensures cleanup.

Reviews (1): Last reviewed commit: "test(ray): give conda-env UDF actor star..." | Re-trigger Greptile

@rohitkulshreshtha rohitkulshreshtha enabled auto-merge (squash) June 9, 2026 22:46
@blacksmith-sh

blacksmith-sh Bot commented Jun 9, 2026

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test_shuffle_reproducible_with_seed[False-arrow] View Logs
coverage: platform linux, python 3.10/12-final-0 View Logs

Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants