fix: respect square thumbnail style in list view#1085
Open
MiMoHo wants to merge 1 commit into
Open
Conversation
List-view thumbnails always applied ROUNDED_CORNERS_SMALL because the isListViewType branch was evaluated before the square-style check in MediaAdapter and DirectoryAdapter. Reorder the when-branches so the square setting (fileRoundedCorners == false / FOLDER_STYLE_SQUARE) is checked first, giving square thumbnails no rounding in both list and grid views while preserving rounded corners otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
List-view thumbnails always rendered with rounded corners even when the user selected the square thumbnail style, while grid view respected the setting. In both
MediaAdapterandDirectoryAdapter, theroundedCornerswhenevaluated theisListViewTypebranch first, so list view unconditionally forcedROUNDED_CORNERS_SMALLand never consulted the square setting (config.fileRoundedCorners == falsefor media,folderStyle == FOLDER_STYLE_SQUAREfor folders).The fix reorders the branches so the square-style check runs first. When the user picks square, thumbnails now get
ROUNDED_CORNERS_NONEin both list and grid views; otherwise the previous behavior is preserved (list = small radius, grid = big radius). This is a minimal, behavior-preserving reorder with no layout or resource changes.Tests performed
Built the
fossDebugvariant and verified on an Android 15 (API 35) emulator:Seeded 5 images; set File thumbnail style=Square (rounded off), switched folder to List view -> thumbnails square-cornered; changed style to Rounded corners -> List view thumbnails rounded. Style now respected in list view. Folder thumbnails also square in grid (Folder style=Square).
Also confirmed
detekt,lint, unit tests and the build all pass locally (CI-equivalent).Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).Coded with Opus 4.8 ultracode.