Skip to content

Dockerfile UI build stage#83

Open
Itaykal wants to merge 18 commits into
mainfrom
dockerfile-build-stages
Open

Dockerfile UI build stage#83
Itaykal wants to merge 18 commits into
mainfrom
dockerfile-build-stages

Conversation

@Itaykal

@Itaykal Itaykal commented Mar 31, 2023

Copy link
Copy Markdown
Contributor

Added a builder stage for the UI instead of doing it externally in a script.

@Itaykal Itaykal self-assigned this Mar 31, 2023
@Itaykal

Itaykal commented Mar 31, 2023

Copy link
Copy Markdown
Contributor Author

I changed the docker cache type from gha to local, the Docker docs say that gha cache exporting is experimental.
Local has its own problems - The cache never clears itself so it must be removed, I added a step that does that as a temp fix

@Itaykal

Itaykal commented Mar 31, 2023

Copy link
Copy Markdown
Contributor Author

Drafting the PR, I have some testing to do with the cache, I want to see if it works as intended and expected

@Itaykal Itaykal marked this pull request as draft March 31, 2023 15:33
@Itaykal

Itaykal commented Mar 31, 2023

Copy link
Copy Markdown
Contributor Author

I changed the docker cache type from gha to local, the Docker docs say that gha cache exporting is experimental. Local has its own problems - The cache never clears itself so it must be removed, I added a step that does that as a temp fix

I tried to understand the differance between them and sounds like gha could be better, reverted

@Itaykal

Itaykal commented Mar 31, 2023

Copy link
Copy Markdown
Contributor Author

Disclaimer: The first run will be 30 minutes or so because nothing is cached

@Itaykal Itaykal marked this pull request as ready for review March 31, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants