LLR Talon Chickens and Malon Minor Logic fix#316
Open
EvilGod50 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is a minor logic bug with Talons Chickens and Song from Malon checks in LLR which puts them in logic if Zelda's letter is obtained, either through glitch's or from the enabled trick, however Zelda's Letter does not determine when these checks are accessible, Wield Egg (Waking Talon) does, thus this PR is for changing Zelda's Letter requirement to Wierd Egg instead (it might cause some small confusion for newer players if they see this on trackers but they can be directed to wake talon at the castle first)
This also now matches closer to upstream ship logic (minus the unimplemented things): https://github.com/HarbourMasters/Shipwright/blob/848106039d02d813f59a6a76b87d3ced233e0eb9/soh/soh/Enhancements/randomizer/location_access/overworld/lon_lon_ranch.cpp#L14 (and Line 41)
Since this is only a issue with skipping talon its a minor one however if someone enables the trick to skip waking talon to get zelda's letter that will put these 2 checks in logic which will result in them being inaccessible with weird egg shuffled.
The alternative to this is making an event for waking Talon depends what you guys are happy with.