Next#7516
Merged
Merged
Conversation
Bumps [axios](https://github.com/axios/axios) from 1.15.0 to 1.15.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.15.0...v1.15.2) --- updated-dependencies: - dependency-name: axios dependency-version: 1.15.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ip-address](https://github.com/beaugunderson/ip-address) and [express-rate-limit](https://github.com/express-rate-limit/express-rate-limit). These dependencies needed to be updated together. Updates `ip-address` from 10.1.0 to 10.2.0 - [Commits](https://github.com/beaugunderson/ip-address/commits) Updates `express-rate-limit` from 8.3.0 to 8.5.1 - [Release notes](https://github.com/express-rate-limit/express-rate-limit/releases) - [Commits](express-rate-limit/express-rate-limit@v8.3.0...v8.5.1) --- updated-dependencies: - dependency-name: ip-address dependency-version: 10.2.0 dependency-type: indirect - dependency-name: express-rate-limit dependency-version: 8.5.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [hono](https://github.com/honojs/hono) from 4.12.14 to 4.12.18. - [Release notes](https://github.com/honojs/hono/releases) - [Commits](honojs/hono@v4.12.14...v4.12.18) --- updated-dependencies: - dependency-name: hono dependency-version: 4.12.18 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates tooling/dependencies and fixes YTMDA authentication token persistence by storing the token in the device cache (matching how the YTM segment reads it). It also adjusts Copilot setup automation to restore the tracked apm.lock.yaml and installs ast-grep-cli.
Changes:
- Bump several Node dependencies in
website/apiviapackage-lock.json. - Fix YTMDA auth to persist the token under
cache.Deviceand update tests to validate the stored token. - Remove legacy
apm.lock, ignore.agents/, and update GitHub automation to restoreapm.lock.yamland installast-grep-cli.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/api/package-lock.json | Updates locked Node dependency versions (axios, express-rate-limit, hono, ip-address). |
| src/cli/auth/ytmda.go | Stores YTMDA token in device cache to match consumer behavior. |
| src/cli/auth/ytmda_test.go | Adjusts tests to assert the token is written to cache rather than pre-seeding it. |
| apm.lock | Removes the untracked/legacy lockfile in favor of apm.lock.yaml. |
| .gitignore | Ignores .agents/ directory. |
| .github/workflows/copilot-setup-steps.yml | Restores apm.lock.yaml, installs ast-grep-cli, and pins checkout to a SHA. |
| .github/github-app.yml | Updates restore command to apm.lock.yaml and installs ast-grep-cli on session creation. |
Files not reviewed (1)
- website/api/package-lock.json: Language not supported
Comment on lines
+98
to
+102
| if tc.shouldSetToken { | ||
| token, ok := cache.Get[string](cache.Device, YTMDATOKEN) | ||
| require.True(t, ok) | ||
| assert.Equal(t, tc.expectedToken, token) | ||
| } |
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v6 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites