Skip to content

Fix Node version and missing PHP extension in CI image#2164

Open
blued-gear wants to merge 13 commits into
mainfrom
upgrade_dependencies-ci_docker
Open

Fix Node version and missing PHP extension in CI image#2164
blued-gear wants to merge 13 commits into
mainfrom
upgrade_dependencies-ci_docker

Conversation

@blued-gear

Copy link
Copy Markdown
Collaborator

Follow-up of #2163

@blued-gear blued-gear requested review from garrettw and melroy89 July 1, 2026 17:23
@garrettw

garrettw commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Looks fine, except that 8.5 breaks composer install. Is there any way you can go ahead and update only the dependencies required to resolve the build errors in this PR? I think it would be good to do those at the same time.

@blued-gear

Copy link
Copy Markdown
Collaborator Author

Is there any way you can go ahead and update only the dependencies required to resolve the build errors in this PR

I can do that, but don't expect it to be just an update. There is an abandoned package (the RSS stuff) which have to be replaced in order to use PHP 8.5

@garrettw

garrettw commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

That's fine to go ahead and do it here, if you can and want to. But if it will take you some time to do, just be mindful of any other PRs that might need CI to work in the meantime.

@blued-gear

Copy link
Copy Markdown
Collaborator Author

I got lucky, the RSS package was incompatible with Symfony 8, not PHP 8.5 :D

Now the linter has new rules. Should I run the fix command to change the affected sourcefiles or disable the rule so that we keep the old style?

@garrettw

garrettw commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

I would disable it for this PR. Then you could make a new PR to re-enable it and fix the affected files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants