Fix Node version and missing PHP extension in CI image#2164
Fix Node version and missing PHP extension in CI image#2164blued-gear wants to merge 13 commits into
Conversation
# Conflicts: # ci/Dockerfile
|
Looks fine, except that 8.5 breaks |
I can do that, but don't expect it to be just an update. There is an abandoned package (the RSS stuff) which have to be replaced in order to use PHP 8.5 |
|
That's fine to go ahead and do it here, if you can and want to. But if it will take you some time to do, just be mindful of any other PRs that might need CI to work in the meantime. |
|
I got lucky, the RSS package was incompatible with Symfony 8, not PHP 8.5 :D Now the linter has new rules. Should I run the fix command to change the affected sourcefiles or disable the rule so that we keep the old style? |
|
I would disable it for this PR. Then you could make a new PR to re-enable it and fix the affected files. |
Follow-up of #2163