fix: remove dead builder methods and CLI output typo#337
Merged
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE320-SQLITE-15208661 - https://snyk.io/vuln/SNYK-ALPINE320-OPENSSL-15121256 - https://snyk.io/vuln/SNYK-ALPINE320-OPENSSL-15121256 - https://snyk.io/vuln/SNYK-ALPINE320-BUSYBOX-14102403 - https://snyk.io/vuln/SNYK-ALPINE320-BUSYBOX-14102404
…6fd7 [Snyk] Security upgrade python from alpine3.20 to 3.15-rc-slim-trixie
Collaborator
Author
|
I'm merging as a reviewer of AI-generated code... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_FlowDefaultsBuilder:_color,display_name,_label,_shape,_safeset(lines 414–433 in the pre-fix file). These were orphaned copies ofElement-level methods accidentally left inside the@dataclassduring the Pydantic migration. They were never called on the builder — the real implementations live on the element classes. Additionally,_labelcalledwrap(...)which is not imported inpytm.py(it's imported inelement.py), meaning any invocation would have raisedNameError. Deletion resolves the latent bug._list_elementstypo fixed:print("\nAtributes:")→print("\nAttributes:"). No test asserted on the misspelled string.Elementadded to_CLASS_REGISTRY:_describe_classesiterated only subclasses ofElement, notElementitself, so--describe Elementerrored with "No such class to describe: Element". One-line fix restores the documented CLI behaviour.Validation