Include *TestSuite classes in the failsafe run#703
Merged
vharseko merged 2 commits intoJul 8, 2026
Merged
Conversation
Issue84TestSuite and OverlappingBackendTestSuite were added in 2024 as regression suites for issues OpenIdentityPlatform#84 and OpenIdentityPlatform#250, but the failsafe include patterns (Test*, *Test, *Tests, *TestCase, *TestCases) never matched the *TestSuite file name, so they have never run in CI. Add the pattern; both suites pass (2/2 and 1/1, ~30 seconds total).
maximthomas
reviewed
Jul 6, 2026
maximthomas
approved these changes
Jul 6, 2026
Co-authored-by: Maxim Thomas <maxim.thomas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue84TestSuiteandOverlappingBackendTestSuitewere added in 2024 as regression suites for #84 (deny-only entry-based ACIs) and #250 (overlapping backends), but the failsafe include patterns (Test*,*Test,*Tests,*TestCase,*TestCases) never matched the*TestSuitefile name — the suites have never run in CI since they were added.Fix
Add
**/*TestSuite.javato the failsafe includes. The pattern picks up exactly the two existing suites (no other*TestSuite.javafiles exist in the repository).Verification
Both suites pass when forced to run:
Issue84TestSuite2/2 (~15s),OverlappingBackendTestSuite1/1 (~16s).Found during the
slowgroup audit follow-up (see #684-#702).