Perf: skip redundant full-image mask on StdShiftIntensity nonzero=False path

[aymuos15]

Fixes #8972 .

Description

On the default nonzero=False path StdShiftIntensity._stdshift built an all-True boolean mask the size of the image and shifted through it (img[slices] = img[slices] + offset), forcing a full advanced-index gather and scatter plus the mask allocation and .any() scan even though every voxel is selected. That is equivalent to shifting the image directly, so the nonzero=False branch now does img + factor * std(img). Output is bit-for-bit identical and the nonzero=True path is untouched. RandStdShiftIntensity benefits too, since it also defaults to nonzero=False. Measured across 2D/3D, single and multi channel, float32 and float64 on both backends (best-of-3, CPU); output verified equal in every configuration:

shape	dtype	backend	current (ms)	proposed (ms)	speedup
1x256x256	f32	numpy	0.123	0.048	2.58x
1x256x256	f32	torch	0.563	0.039	14.47x
1x1024x1024	f32	numpy	3.016	1.294	2.33x
1x1024x1024	f32	torch	7.040	0.274	25.66x
1x1024x1024	f64	torch	9.644	0.601	16.04x
1x64x64x64	f32	numpy	0.637	0.251	2.54x
1x64x64x64	f64	torch	2.646	0.095	27.84x
1x128x128x128	f32	numpy	7.019	2.914	2.41x
1x128x128x128	f32	torch	41.618	0.630	66.09x
1x128x128x128	f64	torch	44.534	1.825	24.40x
4x96x96x96	f32	torch	68.152	1.357	50.23x
4x160x160x160	f32	numpy	128.429	82.662	1.55x
4x160x160x160	f32	torch	342.641	16.727	20.48x
4x160x160x160	f64	torch	354.009	41.652	8.50x

numpy ranges 1.55x to 2.65x and torch 8.5x to 66x across the full sweep; the largest gains are on torch, where all-True boolean-mask indexing is especially costly.

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 33354372-c6d7-4654-9f01-27394197aec5

📥 Commits

Reviewing files that changed from the base of the PR and between f1cc881 and 4031c82.

📒 Files selected for processing (1)

• monai/transforms/intensity/array.py

🚧 Files skipped from review as they are similar to previous changes (1)

• monai/transforms/intensity/array.py

---

📝 Walkthrough

Walkthrough

StdShiftIntensity._stdshift now skips allocating an all-True mask when nonzero=False and uses the full image directly. The nonzero=True path still builds img != 0, checks whether any elements are selected, and applies the shift only to those elements.

File	Change Summary
monai/transforms/intensity/array.py	Simplified the default standard-shift path; preserved masked handling for nonzero inputs.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related issues: #8972

Suggested labels: performance, transforms

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is specific and accurately describes the main performance change in StdShiftIntensity.
Description check	✅ Passed	The description matches the template well and includes the issue link, summary, and change type.
Linked Issues check	✅ Passed	The change removes the redundant full-image mask on the nonzero=False path and preserves nonzero=True behavior.
Out of Scope Changes check	✅ Passed	The only extra detail is a mypy-friendly type narrowing, which is still directly related to the fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}