Skip to content

fix: wrap eval in try/catch #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zspriggs merged 5 commits into from
Jun 30, 2026
+14 −2
Merged

fix: wrap eval in try/catch #2733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b10b49
chore: stop scheduled publish (#2694)
maribethb Jun 12, 2026
ed44882
fix: wrap eval in try/catch
zspriggs Jun 26, 2026
5393f89
chore: update package-lock
zspriggs Jun 26, 2026
28fde39
cleanup package-lock.json
zspriggs Jun 26, 2026
5bf0ded
cleanup commit from main
zspriggs Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion examples/sample-app-ts/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,13 @@ const runCode = () => {

if (outputDiv) outputDiv.innerHTML = '';

eval(code);
// Wrap `eval` in a `try/catch` so that any runtime errors are
// logged to the console, instead of failing quietly.
try {
eval(code);
} catch (error) {
console.log(error);
}
};

if (ws) {
Expand Down
8 changes: 7 additions & 1 deletion examples/sample-app/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,13 @@ const runCode = () => {

outputDiv.innerHTML = '';

eval(code);
// Wrap `eval` in a `try/catch` so that any runtime errors are
// logged to the console, instead of failing quietly.
try {
eval(code);
} catch (error) {
console.log(error);
}
};

// Load the initial state from storage and run the code.
Expand Down
Loading