fix: detect delete areas using pointer coordinates#10078
Merged
Conversation
gonfunko
reviewed
Jun 26, 2026
gonfunko
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10077
Proposed Changes
Dragger: Delete-area detection during pointer drags now uses the cursor position (PointerEvent.clientX/clientY) instead of the block’s workspace origin (getRelativeToSurfaceXY()). Block movement is unchanged; only hit testing for delete styling, drag-target hooks, and drop/delete ononDragEndfollow the pointer.WorkspaceSvg.getDragTarget: Accepts onlyPointerEventonce again.onDragskips delete-area logic when the event is not aPointerEvent;onDragEndcommits without delete-area checks.This effectively reverts one particular change introduced by #9593
Reason for Changes
Previously, deletion could trigger when the block origin overlapped a delete area even if the cursor was elsewhere, for example, dragging a block over the workspace while its top-left corner still intersected the toolbox column. Now, deletion depends on where the user is pointing, not where the block’s origin happens to be.
This conveniently seems to resolve #10076 as well, likely due to
getRelativeToWorkspaceXY()returning the wrong sort of coordinates for zoomed workspaces. (I did not bother to root cause this, but did confirm it's no longer happening.)Test Coverage
New mocha suite simulating realistic drags with delete areas.
onDragEnd.