fix: delete-area hit testing at non-default zoom (#10095)#10096
Merged
Conversation
Contributor
Author
|
CI on this PR is failing because I opened a separate chore PR to fix I rebased |
lizschwab
approved these changes
Jul 2, 2026
lizschwab
left a comment
Contributor
There was a problem hiding this comment.
Looks good once we get CI happy again
This reverts commit 3366b79.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10095
Proposed Changes
Hit-test delete areas now us client/viewport coordinates (
clientX/clientY) instead of a client-to-workspace-to-client round-tripReason for Changes
After #10078, delete styling would still appear at non-default zoom but blocks were not reliably deleted and the trashcan lid did not animate. The coordinate round-trip misaligned hit tests with
getBoundingClientRect()at certain zoom levels, but using client coordinates fixes that.Test Coverage
dragger_test.jswith generated trashcan/toolbox delete tests at zoom 0.7 and 1.5 (delete style, trashcan lid, disposal)