Skip to content

add resizeVector and export at C level#7810

Open
jangorecki wants to merge 1 commit into
masterfrom
resizeVector
Open

add resizeVector and export at C level#7810
jangorecki wants to merge 1 commit into
masterfrom
resizeVector

Conversation

@jangorecki

@jangorecki jangorecki commented Jul 9, 2026

Copy link
Copy Markdown
Member

This C function would be useful for benchmarking for checking impact of new R C API for growable vectors. It could be used

x = rnorm(20)
x = .Call(data.table:::CcopyAsGrowable, x)
.Call(data.table:::CresizeVector, x, 5L)
.Call(data.table:::CresizeVector, x, 10L)

AFAIU resizing from R is currently not possible, so adding this function allows us to do so.

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.99%. Comparing base (fc60d3c) to head (e2ba7a2).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/frollapply.c 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7810      +/-   ##
==========================================
- Coverage   99.01%   98.99%   -0.03%     
==========================================
  Files          88       88              
  Lines       17219    17223       +4     
==========================================
  Hits        17050    17050              
- Misses        169      173       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
  • HEAD=resizeVector much slower for as.data.table.array improved in #7019
  • HEAD=resizeVector much slower for transform improved in #5493
  • HEAD=resizeVector slower P<0.001 for memrecycle regression fixed in #5463
    Comparison Plot

Generated via commit e2ba7a2

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 6 minutes and 28 seconds
Installing different package versions 11 minutes and 49 seconds
Running and plotting the test cases 5 minutes and 27 seconds

@MichaelChirico MichaelChirico requested review from ben-schwen and removed request for MichaelChirico July 9, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant