Skip to content

[Refactor] Declarative construction of config info body #7939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Refactor] Declarative construction of config info body #7939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions packages/app/src/cli/services/format-config-info-body.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,26 +39,26 @@ export function formatConfigInfoBody({
includeConfigOnDeploy,
messages,
}: FormatConfigInfoBodyOptions): TokenItem {
const items = [`App: ${appName}`]
if (org) items.unshift(`Org: ${org}`)
if (devStores && devStores.length > 0) {
devStores.forEach((storeUrl) => items.push(`Dev store: ${storeUrl}`))
}
if (updateURLs) items.push(`Update URLs: ${updateURLs}`)
if (includeConfigOnDeploy !== undefined) items.push(`Include config: ${includeConfigOnDeploy ? 'Yes' : 'No'}`)

let body: Token[] = [{list: {items}}]

if (messages && messages.length) {
for (let index = 0; index < messages.length; index++) {
const message = messages[index]
const items = [
...(org ? [`Org: ${org}`] : []),
`App: ${appName}`,
...(devStores ?? []).map((storeUrl) => `Dev store: ${storeUrl}`),
...(updateURLs ? [`Update URLs: ${updateURLs}`] : []),
...(includeConfigOnDeploy === undefined ? [] : [`Include config: ${includeConfigOnDeploy ? 'Yes' : 'No'}`]),
]

if (!message || message.length === 0) continue
const body: Token[] = [{list: {items}}]

const separator = index === 0 ? '\n' : '\n\n'
if (messages && messages.length > 0) {
const messageTokens = messages.flatMap((message, index) => {
if (message && message.length > 0) {
const separator = index === 0 ? '\n' : '\n\n'
return [separator, ...message]
}
return []
})

body = body.concat(separator, message)
}
return [...body, ...messageTokens]
}

return body
Expand Down
Loading