Add link shop and storefront creation flags by gonzaloriestra · Pull Request #3834 · Shopify/hydrogen

gonzaloriestra · 2026-07-02T08:20:59Z

WHY are these changes introduced?

Fixes https://github.com/shop/issues-develop/issues/22878

shopify hydrogen link still required prompts to choose the shop and name a new storefront, which blocked noninteractive agent runs after project scaffolding.

WHAT is this pull request doing?

Adds --shop, --create-storefront, and --storefront-name to hydrogen link so agents can select a shop and create or link a storefront without prompts.

HOW to test your changes?

Use an unlinked Hydrogen project and a development shop:

shopify hydrogen link --path ./my-hydrogen-app --shop <store>.myshopify.com --storefront "Existing Storefront Name" --force
shopify hydrogen link --path ./my-hydrogen-app --shop <store>.myshopify.com --create-storefront --storefront-name "Agent CLI Test Storefront" --force

Both commands should complete without prompting for shop selection, storefront selection, or the new storefront name.

Post-merge steps

None.

gonzaloriestra · 2026-07-02T08:21:11Z

Use force for upgrade confirmations #3835
Add link shop and storefront creation flags #3834 👈 (View in Graphite)
Skip confirmation prompts on deploy with --force #3832 : 1 other dependent PR (#3833 )
Add env push force confirmation flag #3831
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

shopify · 2026-07-02T11:15:18Z

Oxygen deployed a preview of your gdt-hydrogen-link-create-flags branch. Details:

Storefront	Status	Preview link	Deployment details	Last update (UTC)
Skeleton (skeleton.hydrogen.shop)	✅ Successful (Logs)	Preview deployment	Inspect deployment	July 9, 2026 8:24 AM

Learn more about Hydrogen's GitHub integration.

lucyxiang

Review assisted by pair-review

lucyxiang · 2026-07-03T15:41:52Z

+    });
+
+    it('normalizes CLI flag names before creating a storefront', async () => {
+      await Link.run([


Pair review pointed out this is the only time we use Link.run instead of runLink, which depends on "oclif resolving a Config in the vitest environment, which no other test in the suite relies on". Is this a valid issue- I don't have much context here

Good catch. I replaced this with direct runLink coverage, so this test no longer depends on oclif resolving a Config in the Vitest environment.

lucyxiang · 2026-07-03T15:41:52Z

+    }),
+    'storefront-name': Flags.string({
+      description: 'The name to use when creating a new Hydrogen storefront.',
+      env: 'SHOPIFY_HYDROGEN_STOREFRONT_NAME',


Do we want to use SHOPIFY_HYDROGEN_FLAG_STOREFRONT_NAME like most of the other variables

Updated. The creation name flag now uses the standard flag env var pattern as SHOPIFY_HYDROGEN_FLAG_NAME.

lucyxiang · 2026-07-03T15:41:52Z

+    }),
+    'storefront-name': Flags.string({
+      description: 'The name to use when creating a new Hydrogen storefront.',
+      env: 'SHOPIFY_HYDROGEN_STOREFRONT_NAME',


Thoughts on storefront-create-name/ create-storefront-name ? Since this is only used with create-storefront. I find it confusing there's --storefront and now --storefront-name

Or just --name?

Went with --name. In the hydrogen link command context it reads cleaner than another storefront-prefixed flag, and it avoids the --storefront / --storefront-name ambiguity.

lucyxiang · 2026-07-03T15:41:53Z

        root,
        session,
        storefronts,
+        storefrontName,


This createNewStorefront call sits in the final else branch, which is only reached when flagStorefront is falsy AND (flagCreateStorefront || storefrontName) is also falsy. storefrontName here can only be falsy — passing it implies there is additional data here.

Suggestion: Consider dropping the always-falsy argument

Fixed. The fallback createNewStorefront call no longer passes the name argument from the branch where it can only be absent.

lucyxiang · 2026-07-03T15:41:53Z

-    defaultValue: defaultProjectName,
-  });
+  const projectName =
+    storefrontName ??


The branch selector at line 180 uses a truthy test (flagCreateStorefront || storefrontName) while createNewStorefront uses a nullish fallback (storefrontName ?? renderTextPrompt(...)). An empty string is falsy but not nullish, creating a storefront with a blank name and no prompt (I assume blank name is invalid).

Suggestion: Consider treating a blank --storefront-name as absent (normalize '' to undefined) before the branch decision, or guard against an empty name explicitly, so the || and ?? checks share the same emptiness semantics.

Fixed. The name is trimmed and blank values normalize to undefined before branch selection, with test coverage for the blank-name case.

Add --create-storefront and --storefront-name to hydrogen link so agents can create a new Hydrogen storefront without answering the storefront selection and name prompts.\n\nThe existing --storefront flag remains the explicit existing-storefront path and is validated against the creation flags. Passing --storefront-name implies creating a new storefront and skips the name prompt; passing --create-storefront skips storefront selection and keeps the existing name prompt.\n\nTests cover both creation flags and the conflict with --storefront. The Oclif manifest and changeset are updated for the new user-facing flags.\n\nCloses shop/issues-develop#22878

This was referenced Jul 2, 2026

Add agent-friendly hydrogen init linking flags #3830

Closed

Add env push force confirmation flag #3831

Merged

Skip confirmation prompts on deploy with --force #3832

Merged

Add env pull yes confirmation flag #3833

Closed

gonzaloriestra mentioned this pull request Jul 2, 2026

Use force for upgrade confirmations #3835

Open

gonzaloriestra force-pushed the gdt-hydrogen-env-pull-yes branch from 2caddc8 to f64cea7 Compare July 2, 2026 11:13

gonzaloriestra force-pushed the gdt-hydrogen-link-create-flags branch from b06380d to 8406940 Compare July 2, 2026 11:13

gonzaloriestra force-pushed the gdt-hydrogen-env-pull-yes branch from f64cea7 to 56f192c Compare July 3, 2026 12:10

gonzaloriestra force-pushed the gdt-hydrogen-link-create-flags branch from 8406940 to 2250851 Compare July 3, 2026 12:10

gonzaloriestra changed the title ~~Add link storefront creation flags~~ Add link shop and storefront creation flags Jul 3, 2026

gonzaloriestra changed the base branch from gdt-hydrogen-env-pull-yes to graphite-base/3834 July 3, 2026 12:23

gonzaloriestra force-pushed the graphite-base/3834 branch from 56f192c to b337244 Compare July 3, 2026 12:23

gonzaloriestra force-pushed the gdt-hydrogen-link-create-flags branch from 2250851 to 0147582 Compare July 3, 2026 12:23

gonzaloriestra changed the base branch from graphite-base/3834 to gdt-hydrogen-deploy-yes July 3, 2026 12:23

gonzaloriestra force-pushed the gdt-hydrogen-link-create-flags branch from 0147582 to 97b8c94 Compare July 3, 2026 12:33

gonzaloriestra force-pushed the gdt-hydrogen-deploy-yes branch from b337244 to 019d75b Compare July 3, 2026 12:33

gonzaloriestra force-pushed the gdt-hydrogen-link-create-flags branch from 97b8c94 to 29ebc6c Compare July 3, 2026 14:07

gonzaloriestra marked this pull request as ready for review July 3, 2026 14:29

gonzaloriestra requested a review from a team as a code owner July 3, 2026 14:29

lucyxiang reviewed Jul 3, 2026

View reviewed changes

gonzaloriestra force-pushed the gdt-hydrogen-link-create-flags branch from 29ebc6c to ceded69 Compare July 7, 2026 10:13

gonzaloriestra force-pushed the gdt-hydrogen-deploy-yes branch 2 times, most recently from b941d59 to e2e5d2e Compare July 8, 2026 08:55

gonzaloriestra force-pushed the gdt-hydrogen-link-create-flags branch from ceded69 to bec4169 Compare July 8, 2026 08:55

gonzaloriestra force-pushed the gdt-hydrogen-deploy-yes branch 2 times, most recently from 1085989 to fcc0333 Compare July 8, 2026 09:27

gonzaloriestra force-pushed the gdt-hydrogen-link-create-flags branch 2 times, most recently from a44fa79 to d156023 Compare July 8, 2026 09:44

gonzaloriestra force-pushed the gdt-hydrogen-deploy-yes branch 2 times, most recently from 5852064 to a72a9b3 Compare July 9, 2026 07:44

Add deploy non-preview confirmation flag

286e006

gonzaloriestra force-pushed the gdt-hydrogen-deploy-yes branch from a72a9b3 to 286e006 Compare July 9, 2026 07:50

gonzaloriestra force-pushed the gdt-hydrogen-link-create-flags branch from d156023 to 8612b1e Compare July 9, 2026 08:22

Base automatically changed from gdt-hydrogen-deploy-yes to main July 9, 2026 08:24

Uh oh!

Conversation

gonzaloriestra commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Uh oh!

gonzaloriestra commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shopify Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucyxiang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gonzaloriestra commented Jul 2, 2026 •

edited

Loading

gonzaloriestra commented Jul 2, 2026 •

edited

Loading

shopify Bot commented Jul 2, 2026 •

edited

Loading