SolidOS/solid-panes#709 Remove legacy header#443
Conversation
|
You also have to update https://github.com/SolidOS/mashlib/blob/main/static/browse.html |
|
I would still like this to be tested locally before approving. I just am not sure if I get to this anymore before holiday. Maybe someone else can do it like @bourgeoa |
ebebde2 to
173c9b8
Compare
173c9b8 to
7a4a6c0
Compare
SharonStrats
left a comment
There was a problem hiding this comment.
this works for me locally.
|
I confirm mashlib working locally. |
| <a href="#MainContent" class="skip-link">Skip to main content</a> | ||
|
|
||
| <!-- Header — populated by solid-panes createHeader(), plus responsive menu toggle --> | ||
| <solid-ui-header id="mainSolidUiHeader" theme="" layout="" brand-link="/"> |
There was a problem hiding this comment.
How do you load the header now?
In solid-panes I see document.querySelector('solid-panes-header')
Also I am not sure but you do not call panes.runDataBrowser() anymore anywhere.
There was a problem hiding this comment.
The header is still injected by the createHeader() method in solid-panes, as it says in the comment. What I'm not sure is why it was written here to being with :/. It's possible that I have broken something with this, but I think this is the proper way to do it. Eventually, we should remove everything in this html and just keep a root mount point for the whole app.
The runDataBrowser() is still where it's always been, in the <script> at the top of the file. I did remove it in my initial commit, but I realized that the header wasn't rendering then so I added it back. I also think it shouldn't be there, but I'm trying to keep the changes here small if I can.
|
I'm merging given that without this mashlib is broken. I'm sure there are things to improve, though, but let's address them in follow up PRs. |

This PR is blocked by: