Skip to content

SolidOS/solid-panes#709 Remove legacy header#443

Merged
NoelDeMartin merged 1 commit into
SolidOS:stagingfrom
NoelDeMartin:solid-panes-header
Jul 3, 2026
Merged

SolidOS/solid-panes#709 Remove legacy header#443
NoelDeMartin merged 1 commit into
SolidOS:stagingfrom
NoelDeMartin:solid-panes-header

Conversation

@NoelDeMartin

@NoelDeMartin NoelDeMartin commented Jul 1, 2026

Copy link
Copy Markdown
Member

@NoelDeMartin NoelDeMartin requested a review from timea-solid July 1, 2026 15:08
@timea-solid

Copy link
Copy Markdown
Member

You also have to update https://github.com/SolidOS/mashlib/blob/main/static/browse.html
This is the static mashlib which runs over at: https://solidos.github.io/mashlib/dist/browse.html
At least it should not break.

@timea-solid

Copy link
Copy Markdown
Member

I would still like this to be tested locally before approving. I just am not sure if I get to this anymore before holiday. Maybe someone else can do it like @bourgeoa

@timea-solid timea-solid requested a review from bourgeoa July 2, 2026 11:22
@NoelDeMartin NoelDeMartin force-pushed the solid-panes-header branch 3 times, most recently from ebebde2 to 173c9b8 Compare July 3, 2026 07:43
@NoelDeMartin NoelDeMartin marked this pull request as draft July 3, 2026 07:47
@NoelDeMartin NoelDeMartin marked this pull request as ready for review July 3, 2026 07:50
@SharonStrats SharonStrats self-requested a review July 3, 2026 11:08

@SharonStrats SharonStrats left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works for me locally.

@timea-solid

Copy link
Copy Markdown
Member

I confirm mashlib working locally.
The bowser.html which you can test locally going to: http://localhost:3100/browse.html
looks okis but could be improved:
image

Comment thread src/databrowser.html
<a href="#MainContent" class="skip-link">Skip to main content</a>

<!-- Header — populated by solid-panes createHeader(), plus responsive menu toggle -->
<solid-ui-header id="mainSolidUiHeader" theme="" layout="" brand-link="/">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you load the header now?
In solid-panes I see document.querySelector('solid-panes-header')

Also I am not sure but you do not call panes.runDataBrowser() anymore anywhere.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header is still injected by the createHeader() method in solid-panes, as it says in the comment. What I'm not sure is why it was written here to being with :/. It's possible that I have broken something with this, but I think this is the proper way to do it. Eventually, we should remove everything in this html and just keep a root mount point for the whole app.

The runDataBrowser() is still where it's always been, in the <script> at the top of the file. I did remove it in my initial commit, but I realized that the header wasn't rendering then so I added it back. I also think it shouldn't be there, but I'm trying to keep the changes here small if I can.

@NoelDeMartin

Copy link
Copy Markdown
Member Author

I'm merging given that without this mashlib is broken. I'm sure there are things to improve, though, but let's address them in follow up PRs.

@NoelDeMartin NoelDeMartin merged commit 7787189 into SolidOS:staging Jul 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants