-
Notifications
You must be signed in to change notification settings - Fork 46
Initial RDF forms component #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timea-solid
wants to merge
37
commits into
staging
Choose a base branch
from
rdfComponets
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
0a6d16b
rdf forms component
timea-solid 7c5a7c3
rendered first rdf forms elements
timea-solid 35c066f
preliminary work for rdf-input
timea-solid a20fa4f
Merge branch 'staging' into rdfComponets
timea-solid 5cd82c0
merge staging and moved components
timea-solid 344b904
added also data to forms and wired the rdf input
timea-solid 9d5565a
fixed rdf input
timea-solid 0656653
Refactor for better readability
timea-solid 84345df
fix types
timea-solid 372135f
reverted the sortBySequence code back to original
timea-solid 638786e
Merge branch 'staging' into rdfComponets
timea-solid 235b0d0
vite config for generating custom elements tag name map
timea-solid da5c6fa
Merge branch 'staging' into rdfComponets
timea-solid 35f4445
a first FormsContext with a default store from SolidLogic
timea-solid 0d99a1b
added placeholder property to input
timea-solid 7b7f9a9
added readonly to Input and used it in RDFinput
timea-solid 65735ae
improved store usage
timea-solid cfb0475
added readonly style to input
timea-solid c81b17e
added save features, copied over code
timea-solid 082b9ee
added an updater to the storybook store
timea-solid 2b53d6c
added data change capabilities, 1st version
timea-solid 403a143
Update src/components/input/Input.styles.css
timea-solid 0af9ce9
rename to NoopStore
timea-solid 9d9f48a
renamed NoopStore
timea-solid 3da4992
cleanup from feedback
timea-solid 643dc5a
imporved component type declarations
timea-solid d40ac8b
merge staging
timea-solid b076703
Addeda URL lit converter
timea-solid 242180a
simplify components properties
timea-solid c410374
merge staging
timea-solid 5fdb7bc
random name attribute
timea-solid bfeed32
rework logic of readonly
timea-solid eba9a70
use document instead of uri with fragment
timea-solid c9c7cf3
fixed statement insert
timea-solid a0eaae5
decode defensively
timea-solid d8604c6
small copilot suggested improvments
timea-solid 6280cb4
chnaged from readonly to disabled on select
timea-solid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| node_modules | ||
| dist | ||
| src/versionInfo.ts | ||
| src/types/custom-elements.d.ts | ||
| .idea | ||
| .vscode | ||
| coverage | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,174 @@ | ||
| import { property, state } from 'lit/decorators.js' | ||
| import { html } from 'lit/html.js' | ||
| import { consume } from '@lit/context' | ||
| import { customElement, WebComponent } from '@/lib/components' | ||
| import ns from '../../lib/ns' | ||
| import { fetchData, findForm, sortBySequence } from '../../lib/forms/rdfFormsHelper' | ||
| import { sym, LiveStore } from 'rdflib' | ||
| import '@/components/rdf-input' | ||
| import { DEFAULT_STORE, storeContext, StoreContext } from '@/lib/forms/store/StoreContext' | ||
|
|
||
| const urlConverter = { | ||
| fromAttribute (value: string | null): URL | null { | ||
| if (!value) return null | ||
|
|
||
| try { | ||
| return new URL(value) | ||
| } catch { | ||
| return null | ||
| } | ||
| }, | ||
| toAttribute (value: URL | null) { | ||
| if (!value) return null | ||
| return value | ||
| } | ||
| } | ||
|
|
||
| const hrefFromUrlValue = (value: URL | null): string => | ||
| value?.href ?? '' | ||
|
|
||
| @customElement('solid-ui-rdf-form') | ||
| export default class RDFForm extends WebComponent { | ||
| @consume({ context: storeContext, subscribe: true }) | ||
| private accessor storeContext: StoreContext = DEFAULT_STORE | ||
|
|
||
| @property({ attribute: false }) | ||
| accessor passedInStore: LiveStore | null = null | ||
|
|
||
| private get currentStoreContext (): StoreContext { | ||
| if (this.passedInStore) { | ||
| this.storeContext.store = this.passedInStore | ||
| } | ||
|
|
||
| return this.storeContext | ||
| } | ||
|
Comment on lines
+38
to
+44
|
||
|
|
||
| @state() | ||
| private accessor entireDataIsReadonly: boolean = true // to protect data, we default to not editable | ||
|
|
||
| @state() | ||
| private accessor _loadVersion = 0 | ||
|
|
||
| @state() | ||
| private accessor _documentsLoaded = false | ||
|
|
||
| @property({ converter: urlConverter }) | ||
| accessor formUrl: URL | null = null | ||
|
|
||
| @property({ converter: urlConverter }) | ||
| accessor subjectUrl: URL | null = null | ||
|
|
||
| render () { | ||
| if (!this._documentsLoaded) { | ||
| return html`` | ||
| } | ||
|
|
||
| const store = this.currentStoreContext.store | ||
|
|
||
| const subjectUrl = hrefFromUrlValue(this.subjectUrl) | ||
| if (subjectUrl && store.updater?.editable(subjectUrl) !== undefined && store.updater?.editable(subjectUrl) !== false) { | ||
| this.entireDataIsReadonly = false | ||
| } | ||
|
|
||
| const formRoot = findForm(this.currentStoreContext.store, hrefFromUrlValue(this.formUrl)) // If there are more 'a ui:Form' elements in a form file | ||
| if (!formRoot) throw new Error('No ui:Form found in ' + hrefFromUrlValue(this.formUrl)) | ||
|
|
||
| const formDocument = sym(hrefFromUrlValue(this.formUrl)) // rdflib NamedNode for the document | ||
| const parts = store.each(formRoot, ns.ui('parts'), null, formDocument) | ||
| const partsBySequence = sortBySequence(store, parts) | ||
| const partItems = (partsBySequence || []).flatMap(item => { | ||
| if (item && typeof item === 'object' && 'elements' in item && Array.isArray((item as any).elements)) { | ||
| return (item as any).elements | ||
| } | ||
| return [item] | ||
| }) | ||
| const uiFields = partItems.map(item => { | ||
| const types = store.each(item as any, ns.rdf('type'), null, formDocument) | ||
| const typeNode = types[0] | ||
| const value = typeNode ? ((typeNode as any).value || String(typeNode)) : ((item as any).value || String(item)) | ||
| const hashIndex = value.lastIndexOf('#') | ||
| return { | ||
| value: item, | ||
| fieldValue: hashIndex >= 0 ? value.slice(hashIndex + 1) : value | ||
| } | ||
| }) | ||
|
|
||
| return html` | ||
|
timea-solid marked this conversation as resolved.
|
||
| <form> | ||
| ${uiFields.map(part => { | ||
| switch (part.fieldValue) { | ||
| case 'PhoneField': | ||
| case 'EmailField': | ||
| case 'ColorField': | ||
| case 'DateField': | ||
| case 'DateTimeField': | ||
| case 'TimeField': | ||
| case 'NumericField': | ||
| case 'IntegerField': | ||
| case 'DecimalField': | ||
| case 'FloatField': | ||
| case 'TextField': | ||
| case 'SingleLineTextField': | ||
| case 'NamedNodeURIField': { | ||
| return html` <solid-ui-rdf-input | ||
| .formSubject=${sym(part.value)} | ||
| .dataSubject=${sym(subjectUrl)} | ||
| .storeVersion=${this._loadVersion} | ||
| .readonly=${this.entireDataIsReadonly} | ||
|
Comment on lines
+113
to
+117
|
||
| ></solid-ui-rdf-input> | ||
| <br>` | ||
| } | ||
| case 'MultiLineTextField': | ||
| return html`<input .rdf=${part}></input>` | ||
| case 'BooleanField': | ||
| return html`<input .rdf=${part}></input>` | ||
| case 'TristateField': | ||
| return html`<input .rdf=${part}></input>` | ||
| case 'Classifier': | ||
| return html`<input .rdf=${part}></input>` | ||
| case 'Choice': | ||
| return html`<input .rdf=${part}></input>` | ||
| case 'Multiple': | ||
| return html`<input .rdf=${part}></input>` | ||
| case 'Options': | ||
| return html`<input .rdf=${part}></input>` | ||
| case 'AutocompleteField': | ||
| return html`<input .rdf=${part}></input>` | ||
| case 'Comment': | ||
| case 'Heading': | ||
| return html`<input .rdf=${part}></input>` | ||
| default: | ||
| return html`<div>Unknown part type: ${part}</div>` | ||
| } | ||
| })} | ||
| </form> | ||
| ` | ||
| } | ||
|
|
||
| protected updated (changedProperties: Map<PropertyKey, unknown>) { | ||
| super.updated(changedProperties) | ||
| if (changedProperties.has('formUrl') || | ||
| changedProperties.has('subjectUrl') || | ||
| changedProperties.has('passedInStore') | ||
| ) { | ||
| this.loadDocumentsIfNeeded() | ||
| } | ||
| } | ||
|
|
||
| private async loadDocumentsIfNeeded () { | ||
| const store = this.currentStoreContext.store | ||
| const formUrl = hrefFromUrlValue(this.formUrl) | ||
| const subjectUrl = hrefFromUrlValue(this.subjectUrl) | ||
|
|
||
| if (!formUrl || !subjectUrl) return | ||
|
|
||
| try { | ||
| await fetchData(store, formUrl) | ||
| await fetchData(store, subjectUrl) | ||
| this._loadVersion += 1 | ||
| this._documentsLoaded = true | ||
| } catch (error) { | ||
| console.error('Failed to load RDF documents', error) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { html } from 'lit' | ||
| import { defineStoryRender } from '../../storybook' | ||
| import './RDFForm' | ||
|
timea-solid marked this conversation as resolved.
|
||
|
|
||
| const meta = { | ||
| title: 'Design System/RDF Form', | ||
| args: { | ||
| formUrl: 'https://solidos.solidcommunity.net/public/2021/solidUiFormTestData/dummyFormTestFile.ttl', // we need a working URL | ||
| subjectUrl: 'https://solidos.solidcommunity.net/public/2021/alice.ttl#me' | ||
| }, | ||
|
|
||
| argTypes: { | ||
| formUrl: { control: 'text' }, | ||
| subjectUrl: { control: 'text' } | ||
| }, | ||
| } as const | ||
|
|
||
| const render = defineStoryRender<typeof meta.argTypes>(({ formUrl, subjectUrl }) => { | ||
| return html` | ||
| <solid-ui-rdf-form | ||
| formUrl=${formUrl} | ||
| .subjectUrl=${new URL(subjectUrl)}> | ||
| </solid-ui-rdf-form> | ||
| ` | ||
| }) | ||
|
|
||
| export default meta | ||
|
|
||
| export const Primary = { render } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import RDFForm from './RDFForm' | ||
|
|
||
| export { RDFForm } | ||
| export default RDFForm |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.